Skip to content

Commit 0c09b02

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
[test] Fix flaky tests
I look it in debug more, and i think its possible that the link is off screen under a scrollbar. We should improve our click handler to handle these cases. No-Tree-Checks: True Bug: none Change-Id: I63c7c5f4f7db2adef339738d74da1055577ae620 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6264606 Commit-Queue: Nikolay Vitkov <[email protected]> Reviewed-by: Andres Olivares <[email protected]> Reviewed-by: Mathias Bynens <[email protected]>
1 parent 6cf2d2c commit 0c09b02

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/e2e/performance/selector-stats-tracing_test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import {assert} from 'chai';
66

7-
import {click, getBrowserAndPages, step, waitForFunction} from '../../shared/helper.js';
7+
import {click, getBrowserAndPages, scrollElementIntoView, step, waitForFunction} from '../../shared/helper.js';
88
import {reloadDevTools} from '../helpers/cross-tool-helper.js';
99
import {getDataGridRows} from '../helpers/datagrid-helpers.js';
1010
import {
@@ -75,6 +75,7 @@ describe('The Performance panel', function() {
7575
});
7676

7777
await step('Validate source file is open via available link in selector stats table', async () => {
78+
await scrollElementIntoView('devtools-linkifier');
7879
await click('devtools-linkifier');
7980
// Look at source tabs
8081
await validateSourceTabs();

0 commit comments

Comments
 (0)