Reveal the CookieReportView by selecting sidebar element

This fixes the issue where the someone may click a console message
that reveals the CookieReportView, but the wrong sidebar element is
highlighted. By making the revealer select the sidebar element
directly, we allow the sidebar to manage showing the the
CookieReportView as it would with a normal user selection.

Bug:394934461
Change-Id: Iada064f42db049ce7e9a0f40c0438886684e891e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6241738
Reviewed-by: Shuran Huang <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Shuran Huang <[email protected]>

Author: masnoble

front_end/panels/security/SecurityPanel.ts

@@ -1624,15 +1624,16 @@ export interface OriginState {
 export type Origin = Platform.DevToolsPath.UrlString;
 
 export class SecurityRevealer implements Common.Revealer.Revealer<CookieReportView> {
-  async reveal(cookieReportView: CookieReportView): Promise<void> {
+  async reveal(): Promise<void> {
     await UI.ViewManager.ViewManager.instance().showView('security');
     const view = UI.ViewManager.ViewManager.instance().view('security');
     if (view) {
       const securityPanel = await view.widget();
-      if (securityPanel instanceof SecurityPanel) {
-        securityPanel.setVisibleView(cookieReportView);
+      if (securityPanel instanceof SecurityPanel && securityPanel.sidebar.cookieReportTreeElement) {
+        securityPanel.sidebar.cookieReportTreeElement.select(/* omitFocus=*/ false, /* selectedByUser=*/ true);
       } else {
-        throw new Error('Expected securityPanel to be an instance of SecurityPanel');
+        throw new Error(
+            'Expected securityPanel to be an instance of SecurityPanel with a cookieReportTreeElement in the sidebar');
       }
     }
   }

front_end/panels/security/SecurityPanelSidebar.ts

@@ -75,7 +75,7 @@ export class SecurityPanelSidebar extends UI.Widget.VBox {
   #originGroups: Map<OriginGroup, UI.TreeOutline.TreeElement>;
   securityOverviewElement: OriginTreeElement;
   readonly #cookieControlsTreeElement: CookieControlsTreeElement|undefined;
-  readonly #cookieReportTreeElement: CookieReportTreeElement|undefined;
+  readonly cookieReportTreeElement: CookieReportTreeElement|undefined;
   readonly #elementsByOrigin: Map<string, OriginTreeElement>;
   readonly #mainViewReloadMessage: UI.TreeOutline.TreeElement;
   #mainOrigin: string|null;
@@ -97,8 +97,8 @@ export class SecurityPanelSidebar extends UI.Widget.VBox {
       this.#cookieControlsTreeElement =
           new CookieControlsTreeElement(i18nString(UIStrings.flagControls), 'cookie-flag-controls');
       privacyTreeSection.appendChild(this.#cookieControlsTreeElement);
-      this.#cookieReportTreeElement = new CookieReportTreeElement(i18nString(UIStrings.cookieReport), 'cookie-report');
-      privacyTreeSection.appendChild(this.#cookieReportTreeElement);
+      this.cookieReportTreeElement = new CookieReportTreeElement(i18nString(UIStrings.cookieReport), 'cookie-report');
+      privacyTreeSection.appendChild(this.cookieReportTreeElement);
 
       // If this if the first time this setting is set, go to the controls tool
       if (this.#securitySidebarLastItemSetting.get() === '') {
@@ -175,10 +175,10 @@ export class SecurityPanelSidebar extends UI.Widget.VBox {
       this.#cookieControlsTreeElement.select();
       this.#cookieControlsTreeElement.showElement();
     } else if (
-        this.#cookieReportTreeElement &&
-        this.#securitySidebarLastItemSetting.get() === this.#cookieReportTreeElement.elemId) {
-      this.#cookieReportTreeElement.select();
-      this.#cookieReportTreeElement.showElement();
+        this.cookieReportTreeElement &&
+        this.#securitySidebarLastItemSetting.get() === this.cookieReportTreeElement.elemId) {
+      this.cookieReportTreeElement.select();
+      this.cookieReportTreeElement.showElement();
     } else {
       this.securityOverviewElement.select();
       this.securityOverviewElement.showElement();