[lint] Read lit-analyzer options from toplevel tsconfig.json.

This way the config is in a central place and can be reused for
ts-lit-plugin.

Bug: 375149136
Change-Id: Ic3805b059b5c9b0d103a152e1ff36b3c9c5245b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953717
Auto-Submit: Benedikt Meurer <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>

Author: bmeurer

scripts/devtools_paths.js

@@ -129,6 +129,15 @@ function litAnalyzerExecutablePath() {
   return path.join(nodeModulesPath(), 'lit-analyzer', 'cli.js');
 }
 
+/**
+ * Computes the path to the toplevel `tsconfig.json`.
+ *
+ * @returns the path to the toplevel `tsconfig.json`.
+ */
+function tsconfigJsonPath() {
+  return path.join(devtoolsRootPath(), 'tsconfig.json');
+}
+
 function downloadedChromeBinaryPath() {
   const paths = {
     linux: path.join('chrome-linux', 'chrome'),
@@ -146,5 +155,6 @@ module.exports = {
   mochaExecutablePath,
   stylelintExecutablePath,
   downloadedChromeBinaryPath,
-  litAnalyzerExecutablePath
+  litAnalyzerExecutablePath,
+  tsconfigJsonPath,
 };

scripts/test/run_lint_check.js

@@ -13,12 +13,14 @@ const yargs = require('yargs/yargs');
 const {hideBin} = require('yargs/helpers');
 const childProcess = require('child_process');
 const {promisify} = require('util');
+const {readFileSync} = require('fs');
 const spawnAsync = promisify(childProcess.spawnSync);
 
 const {
   devtoolsRootPath,
   litAnalyzerExecutablePath,
   nodePath,
+  tsconfigJsonPath,
 } = require('../devtools_paths.js');
 
 const flags = yargs(hideBin(process.argv))
@@ -91,14 +93,25 @@ async function runStylelint(files) {
 }
 
 /**
- * @param {string[]} files
+ * Runs the `lit-analyzer` on the `files`.
+ *
+ * The configuration for the `lit-analyzer` is parsed from the options for
+ * the "ts-lit-plugin" from the toplevel `tsconfig.json` file.
+ *
+ * @param {string[]} files the input files to analyze.
  */
 async function runLitAnalyzer(files) {
-  const rules = {
-    'no-missing-import': 'error',
-    'no-unknown-tag-name': 'error',
-    'no-complex-attribute-binding': 'off',
+  const readLitAnalyzerConfigFromCompilerOptions = () => {
+    const {compilerOptions} = JSON.parse(readFileSync(tsconfigJsonPath(), 'utf-8'));
+    const {plugins} = compilerOptions;
+    const tsLitPluginOptions = plugins.find(plugin => plugin.name === 'ts-lit-plugin');
+    if (tsLitPluginOptions === null) {
+      throw new Error(`Failed to find ts-lit-plugin options in ${tsconfigJsonPath()}`);
+    }
+    return tsLitPluginOptions;
   };
+
+  const {rules} = readLitAnalyzerConfigFromCompilerOptions();
   const getLitAnalyzerResult = async subsetFiles => {
     const args = [
       litAnalyzerExecutablePath(),

tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "./config/typescript/tsconfig.base.json",
   "compilerOptions": {
+    "allowUmdGlobalAccess": true,
     "lib": [
       "esnext",
       "dom",
@@ -9,7 +10,16 @@
       "webworker.iterable"
     ],
     "outDir": "ignored-for-vscode",
-    "allowUmdGlobalAccess": true
+    "plugins": [
+      {
+        "name": "ts-lit-plugin",
+        "rules": {
+          "no-complex-attribute-binding": "off",
+          "no-missing-import": "error",
+          "no-unknown-tag-name": "error"
+        }
+      }
+    ]
   },
   "include": [
     "front_end/",