RPP: deal with clearing annotations bug when count === 0

Fixed: 395482394
Change-Id: I8b63f04e88e4f57464dc69217a9d6f47ee5671db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6244428
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
Commit-Queue: Kateryna Prokopenko <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>

Author: jackfranklin

front_end/panels/timeline/components/Sidebar.test.ts

@@ -6,6 +6,7 @@ import * as Trace from '../../../models/trace/trace.js';
 import {raf, renderElementIntoDOM} from '../../../testing/DOMHelpers.js';
 import {describeWithEnvironment} from '../../../testing/EnvironmentHelpers.js';
 import {TraceLoader} from '../../../testing/TraceLoader.js';
+import * as RenderCoordinator from '../../../ui/components/render_coordinator/render_coordinator.js';
 
 import * as Components from './components.js';
 
@@ -119,4 +120,27 @@ describeWithEnvironment('Sidebar', () => {
     const countBadge = annotationsTab.querySelector<HTMLElement>('.badge');
     assert.strictEqual(countBadge?.innerText, '1');
   });
+
+  it('removes the annotations badge when the user deletes the final annotation', async function() {
+    const {parsedTrace, metadata} = await TraceLoader.traceEngine(this, 'web-dev-with-commit.json.gz');
+    const entryLabelAnnotation: Trace.Types.File.Annotation = {
+      type: 'ENTRY_LABEL',
+      entry: parsedTrace.Renderer.allTraceEntries[0],  // random event, doesn't matter
+      label: 'hello world',
+    };
+
+    const sidebar = await renderSidebar(parsedTrace, metadata, null);
+    sidebar.setAnnotations([entryLabelAnnotation], new Map());
+    await RenderCoordinator.done();
+    const tabbedPane = sidebar.element.querySelector('.tabbed-pane')?.shadowRoot;
+    assert.isOk(tabbedPane);
+    const annotationsTab = tabbedPane.querySelector('#tab-annotations');
+    assert.isOk(annotationsTab);
+    const countBadge = annotationsTab.querySelector<HTMLElement>('.badge');
+    assert.strictEqual(countBadge?.innerText, '1');
+
+    sidebar.setAnnotations([], new Map());  // delete the annotations
+    const updatedCountBadge = annotationsTab.querySelector<HTMLElement>('.badge');
+    assert.isNull(updatedCountBadge);  // No badge is shown when the count is 0.
+  });
 });

front_end/panels/timeline/components/Sidebar.ts

@@ -103,9 +103,7 @@ export class SidebarWidget extends UI.Widget.VBox {
 
   #updateAnnotationsCountBadge(): void {
     const annotations = this.#annotationsView.deduplicatedAnnotations();
-    if (annotations.length) {
-      this.#tabbedPane.setBadge('annotations', annotations.length.toString());
-    }
+    this.#tabbedPane.setBadge('annotations', annotations.length > 0 ? annotations.length.toString() : null);
   }
 
   setParsedTrace(parsedTrace: Trace.Handlers.Types.ParsedTrace|null, metadata: Trace.Types.File.MetaData|null): void {