[Ai Assistance] Fix history delete regression

Use the Id of the conversation as the Agent may not exits.

Bug: 399792007
Change-Id: I5f7076f00a9e290ba734090d4ea4eda46849ec92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6311453
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>

Author: Lightning00Blade

front_end/panels/ai_assistance/AiAssistancePanel.test.ts

@@ -11,7 +11,8 @@ import {
   cleanup,
   createAiAssistancePanel,
   createNetworkRequest,
-  mockAidaClient
+  mockAidaClient,
+  openHistoryContextMenu
 } from '../../testing/AiAssistanceHelpers.js';
 import {findMenuItemWithLabel, getMenu} from '../../testing/ContextMenuHelpers.js';
 import {createTarget, registerNoopActions, updateHostConfig} from '../../testing/EnvironmentHelpers.js';
@@ -634,11 +635,64 @@ describeWithMockConnection('AI Assistance Panel', () => {
           addHistoryItemStub, sinon.match({type: 'answer', text: 'partially started and now it\'s finished'}));
       sinon.assert.neverCalledWith(addHistoryItemStub, sinon.match({type: 'answer', text: 'partially started'}));
     });
+
+    it('should switch agents and restore history and allow a single delete', async () => {
+      updateHostConfig({
+        devToolsFreestyler: {
+          enabled: true,
+        },
+      });
+      const {panel, expectViewUpdate} = await createAiAssistancePanel(
+          {
+            aidaClient: mockAidaClient(
+                [
+                  [{explanation: 'test'}],
+                  [{explanation: 'test2'}],
+                ],
+                ),
+          },
+      );
+      const updateViewInput = await expectViewUpdate(() => {
+        panel.handleAction('freestyler.elements-floating-button');
+      });
+      await expectViewUpdate(() => {
+        updateViewInput.onTextSubmit('User question to Freestyler?');
+      });
+
+      const updatedViewInputAfterSwitchToNetwork = await expectViewUpdate(() => {
+        panel.handleAction('drjones.network-floating-button');
+      });
+      await expectViewUpdate(() => {
+        updatedViewInputAfterSwitchToNetwork.onTextSubmit('User question to DrJones?');
+      });
+
+      const {contextMenu, id} =
+          openHistoryContextMenu(updatedViewInputAfterSwitchToNetwork, 'User question to Freestyler?');
+      assert.isDefined(id);
+      const updatedViewInput = await expectViewUpdate(() => {
+        contextMenu.invokeHandler(id);
+      });
+
+      const stub = sinon.createStubInstance(AiAssistance.AiHistoryStorage);
+      sinon.stub(AiAssistance.AiHistoryStorage, 'instance').returns(stub);
+      const updateDeleteSingle = await expectViewUpdate(() => {
+        updatedViewInput.onDeleteClick();
+      });
+
+      assert.deepEqual(updateDeleteSingle.messages, []);
+      assert.strictEqual(stub.deleteHistoryEntry.callCount, 1);
+      assert.isString(stub.deleteHistoryEntry.lastCall.args[0]);
+
+      const menuAfterDelete =
+          openHistoryContextMenu(updatedViewInputAfterSwitchToNetwork, 'User question to Freestyler?');
+      assert.isUndefined(menuAfterDelete.id);
+    });
   });
 
   it('should have empty state after clear chat', async () => {
-    const {panel, expectViewUpdate} =
-        await createAiAssistancePanel({aidaClient: mockAidaClient([[{explanation: 'test'}]])});
+    const {panel, expectViewUpdate} = await createAiAssistancePanel({
+      aidaClient: mockAidaClient([[{explanation: 'test'}]]),
+    });
 
     const updatedViewInput = await expectViewUpdate(() => {
       panel.handleAction('freestyler.elements-floating-button');

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -608,12 +608,13 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
     if (!agent) {
       this.#conversation = undefined;
+      // We need to run doConversation separately
+      this.#messages = [];
       // If a no new agent is provided
       // but conversation is
       // update with history conversation
       if (conversation) {
         this.#conversation = conversation;
-        this.#messages = [];
       }
     }
 
@@ -1091,11 +1092,13 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   #onDeleteClicked(): void {
-    if (this.#conversationAgent) {
-      this.#historicalConversations =
-          this.#historicalConversations.filter(conversation => conversation !== this.#conversation);
-      void AiHistoryStorage.instance().deleteHistoryEntry(this.#conversationAgent.id);
+    if (!this.#conversation) {
+      return;
     }
+
+    this.#historicalConversations =
+        this.#historicalConversations.filter(conversation => conversation !== this.#conversation);
+    void AiHistoryStorage.instance().deleteHistoryEntry(this.#conversation.id);
     this.#updateConversationState();
     UI.ARIAUtils.alert(i18nString(UIStrings.chatDeleted));
   }

front_end/testing/AiAssistanceHelpers.ts

@@ -11,6 +11,7 @@ import * as Logs from '../models/logs/logs.js';
 import type * as Workspace from '../models/workspace/workspace.js';
 import * as AiAssistance from '../panels/ai_assistance/ai_assistance.js';
 
+import {findMenuItemWithLabel, getMenu} from './ContextMenuHelpers.js';
 import {
   createTarget,
 } from './EnvironmentHelpers.js';
@@ -263,3 +264,17 @@ export function cleanup() {
   }
   patchWidgets = [];
 }
+
+export function openHistoryContextMenu(
+    lastUpdate: AiAssistance.ViewInput,
+    item: string,
+) {
+  const contextMenu = getMenu(() => {
+    lastUpdate.onHistoryClick(new MouseEvent('click'));
+  });
+  const freestylerEntry = findMenuItemWithLabel(contextMenu.defaultSection(), item);
+  return {
+    contextMenu,
+    id: freestylerEntry?.id(),
+  };
+}