Support all Chrome channels

Also add support for binary to point to executable of your
choice.

Bug: none
Change-Id: I122ad4fd117241c0c0106e2896e4fca602791958
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397059
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

docs/get_the_code.md

@@ -115,6 +115,7 @@ gclient sync
 The revisions of git dependencies must always be in sync between the entry in DEPS and the git submodule. PRESUBMIT will
 reject CLs that try to submit changes to one but not the other.
 It can happen that dependencies go out of sync for three main reasons:
+
 1. The developer attempted a manual roll by only updating the DEPS file (which was the process before migrating to git
    submodules, see [below](#Managing-dependencies)),
 1. after switching branches or checking out new commit the developer didn't run `gclient sync`, or
@@ -195,7 +196,7 @@ Note that `$(realpath out/Default/gen/front_end)` expands to the absolute path t
 
 Open DevTools via F12 or Ctrl+Shift+J on Windows/Linux or Cmd+Option+I on Mac.
 
-If you get errors along the line of `Uncaught TypeError: Cannot read property 'setInspectedTabId'` you probably specified an incorrect path - the path has to be absolute. On Mac and Linux, the file url will start with __three__ slashes: `file:///Users/...`.
+If you get errors along the line of `Uncaught TypeError: Cannot read property 'setInspectedTabId'` you probably specified an incorrect path - the path has to be absolute. On Mac and Linux, the file url will start with **three** slashes: `file:///Users/...`.
 
 **Tip**: You can inspect DevTools with DevTools by undocking DevTools and then opening a second instance of DevTools (see keyboard shortcut above).
 
@@ -226,6 +227,7 @@ Then start Chrome, allowing for accesses from the web server:
 ```
 
 Get the list of pages together with their DevTools frontend URLs:
+
 ```bash
 $ curl http://localhost:9222/json -s | grep '\(url\|devtoolsFrontend\)'
    "devtoolsFrontendUrl": "/devtools/inspector.html?ws=localhost:9222/devtools/page/BADADD4E55BADADD4E55BADADD4E5511",

scripts/run_start.mjs

@@ -2,12 +2,17 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import {computeSystemExecutablePath} from '@puppeteer/browsers';
 import childProcess from 'node:child_process';
 import path from 'node:path';
 import yargs from 'yargs';
 import {hideBin} from 'yargs/helpers';
 
-import {downloadedChromeBinaryPath, isInChromiumDirectory, rootPath} from './devtools_paths.js';
+import {
+  downloadedChromeBinaryPath,
+  isInChromiumDirectory,
+  rootPath,
+} from './devtools_paths.js';
 
 // The list of features that are enabled by default.
 const ENABLE_FEATURES = [
@@ -29,9 +34,17 @@ if (process.platform === 'darwin') {
 const argv = yargs(hideBin(process.argv))
                  .option('browser', {
                    type: 'string',
-                   choices: ['cft', 'canary'],
+                   // CfT is not downloaded in Chromium checkout
                    default: isInChromiumDirectory().isInChromium ? 'canary' : 'cft',
-                   description: 'Launch in the specified browser',
+                   description: 'Launch in specified Chrome channel, CfT or a custom binary',
+                   coerce(arg) {
+                     if (arg.includes(path.sep) || arg.includes(path.posix.sep) ||
+                         ['cft', 'stable', 'beta', 'dev', 'canary'].includes(arg)) {
+                       return arg;
+                     }
+
+                     throw new Error(`Unsupported channel "${arg}"`);
+                   },
                  })
                  .option('open', {
                    type: 'boolean',
@@ -60,32 +73,38 @@ const {env} = process;
 const runBuildPath = path.join(import.meta.dirname, 'run_build.mjs');
 
 function findBrowserBinary() {
-  if (browser === 'canary') {
-    const binary = ({
-      linux: path.join('/usr', 'bin', 'google-chrome-unstable'),
-      darwin: path.join('/Applications', 'Google Chrome Canary.app', 'Contents', 'MacOS', 'Google Chrome Canary'),
-    })[process.platform];
+  if (browser === 'cft') {
+    const binary = downloadedChromeBinaryPath();
+    if (verbose) {
+      console.debug('Located Chrome for Testing binary at %s.', binary);
+    }
+    return binary;
+  }
+
+  if (['stable', 'beta', 'dev', 'canary'].includes(browser)) {
+    const binary = computeSystemExecutablePath({
+      browser: 'chrome',
+      channel: browser,
+    });
+
     if (verbose) {
-      console.debug('Located Chrome Canary binary in %s.', binary);
+      console.debug(`Located Chrome ${browser} binary at ${binary}.`);
     }
     return binary;
   }
-  const binary = downloadedChromeBinaryPath();
+
   if (verbose) {
-    console.debug('Located Chrome for Testing binary in %s.', binary);
+    console.debug(`Launching custom binary at ${binary}.`);
   }
-  return binary;
+  return browser;
 }
 
 // Perform the initial build.
-childProcess.spawnSync(
-    process.argv[0],
-    [
-      runBuildPath,
-      `--target=${target}`,
-    ],
-    {cwd, env, stdio: 'inherit'},
-);
+childProcess.spawnSync(process.argv[0], [runBuildPath, `--target=${target}`], {
+  cwd,
+  env,
+  stdio: 'inherit',
+});
 
 // Launch Chrome with our custom DevTools front-end.
 function start() {
@@ -130,13 +149,9 @@ function start() {
 // devtools-frontend whenever there are changes detected.
 const watcher = childProcess.spawn(
     process.argv[0],
-    [
-      runBuildPath,
-      '--skip-initial-build',
-      `--target=${target}`,
-      '--watch',
-    ],
-    {cwd, env, stdio: 'inherit'});
+    [runBuildPath, '--skip-initial-build', `--target=${target}`, '--watch'],
+    {cwd, env, stdio: 'inherit'},
+);
 try {
   // Launch chrome.
   start();