Skip to content

Commit 0fc3b71

Browse files
danilsomsikovDevtools-frontend LUCI CQ
authored andcommitted
Revert "[test] Disable expectVeEvents check to see if it reduces flakyness"
This reverts commit cc78980. Reason for revert: Doesn't help with Mac crashes Bug: 433924805 Original change's description: > [test] Disable expectVeEvents check to see if it reduces flakyness > > Bug: 433924805 > Change-Id: I7c27b63b002d6fdb10033f19d36143da9ac76fab > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6797950 > Auto-Submit: Danil Somsikov <[email protected]> > Reviewed-by: Philip Pfaffe <[email protected]> > Commit-Queue: Danil Somsikov <[email protected]> Bug: 433924805 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I1514ea73560612e5b5074d580728d49b0842924c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6802443 Commit-Queue: Danil Somsikov <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
1 parent 45572d7 commit 0fc3b71

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

test/e2e/helpers/visual-logging-helpers.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,12 +158,11 @@ export async function dumpVeEvents(label: string) {
158158
// Unexpected VE events are ignored.
159159
export async function expectVeEvents(
160160
expectedEvents: TestLogEntry[], root?: string,
161-
_devToolsPage: DevToolsPage = getBrowserAndPagesWrappers().devToolsPage) {
161+
devToolsPage: DevToolsPage = getBrowserAndPagesWrappers().devToolsPage) {
162162
collapseConsecutiveImpressions(expectedEvents);
163163
prependRoot(expectedEvents, root);
164-
// TODO(crbug.com/433924805): Re-eneable or fix this when confirmed if this affects test flakyness.
165-
// // @ts-expect-error
166-
// await devToolsPage.evaluate(async expectedEvents => await globalThis.expectVeEvents(expectedEvents), expectedEvents);
164+
// @ts-expect-error
165+
await devToolsPage.evaluate(async expectedEvents => await globalThis.expectVeEvents(expectedEvents), expectedEvents);
167166
}
168167

169168
function collapseConsecutiveImpressions(events: TestLogEntry[]) {

0 commit comments

Comments
 (0)