Fix "Learn more" in FRE dialog not announcing the extra context

The aria-label on devtools-button does not work, instead we need to add
title to enclosed button for announcement to work in Windows. Also
renamed learnMoreButtonTitle to learnMoreButtonText so that it is more
clear.

Also, fixed settings text which got missed previously

Fixed: 441578543, 440553443
Change-Id: I2354a4d47958af53af1e742b29eadfbadf0f75e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6904712
Commit-Queue: Samiya Caur <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>

Author: Samiya Caur

front_end/panels/ai_assistance/PatchWidget.ts

@@ -599,7 +599,7 @@ export class PatchWidget extends UI.Widget.Widget {
         void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
       },
       ariaLabel: lockedString(UIStringsNotTranslate.freDisclaimerHeader),
-      learnMoreButtonTitle: lockedString(UIStringsNotTranslate.learnMore),
+      learnMoreButtonText: lockedString(UIStringsNotTranslate.learnMore),
     });
 
     if (result) {

front_end/panels/common/FreDialog.ts

@@ -36,7 +36,7 @@ const str_ = i18n.i18n.registerUIStrings('panels/common/FreDialog.ts', UIStrings
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class FreDialog {
-  static show({header, reminderItems, onLearnMoreClick, ariaLabel, learnMoreButtonTitle, learnMoreButtonAriaLabel}: {
+  static show({header, reminderItems, onLearnMoreClick, ariaLabel, learnMoreButtonText, learnMoreButtonAriaLabel}: {
     header: {
       iconName: string,
       text: Platform.UIString.LocalizedString,
@@ -47,7 +47,7 @@ export class FreDialog {
     }>,
     onLearnMoreClick: () => void,
     ariaLabel?: string,
-    learnMoreButtonTitle?: string,
+    learnMoreButtonText?: string,
     learnMoreButtonAriaLabel?: string,
   }): Promise<boolean> {
     const dialog = new UI.Dialog.Dialog();
@@ -83,8 +83,9 @@ export class FreDialog {
             @click=${onLearnMoreClick}
             .jslogContext=${'fre-disclaimer.learn-more'}
             .variant=${Buttons.Button.Variant.OUTLINED}
+            .title=${learnMoreButtonAriaLabel ?? i18nString(UIStrings.learnMore)}
             aria-label=${ifDefined(learnMoreButtonAriaLabel)}>
-            ${learnMoreButtonTitle ?? i18nString(UIStrings.learnMore)}
+            ${learnMoreButtonText ?? i18nString(UIStrings.learnMore)}
           </devtools-button>
           <div class="right-buttons">
             <devtools-button

front_end/panels/settings/AISettingsTab.ts

@@ -177,12 +177,12 @@ const UIStrings = {
    * @description Explainer for which data is being sent for the 'Code suggestions' feature
    */
   codeSuggestionsSendData:
-      'To generate annotation suggestions, your performance trace is sent to Google. This data may be seen by human reviewers to improve this feature.',
+      'To generate code suggestions, your console input, the history of your current console session, the currently inspected CSS, and the contents of the currently open file are shared with Google. This data may be seen by human reviewers to improve this feature.',
   /**
    * @description Explainer for which data is being sent for the 'Code suggestions' feature when logging is not enabled
    */
   codeSuggestionsSendDataNoLogging:
-      'To generate annotation suggestions, your performance trace is sent to Google. This data will not be used to improve Google’s AI models. Your organization may change these settings at any time.',
+      'To generate code suggestions, your console input, the history of your current console session, the currently inspected CSS, and the contents of the currently open file are shared with Google. This data will not be used to improve Google’s AI models. Your organization may change these settings at any time.',
   /**
    * @description Label for a link to the terms of service
    */

front_end/panels/timeline/overlays/OverlaysImpl.test.ts

@@ -517,7 +517,7 @@ describeWithEnvironment('Overlays', () => {
          // This dialog should be visible
          assert.isTrue(showFreDialogStub.called, 'Expected FreDialog to be shown but it\'s not shown');
 
-         const customLearnMoreButtonTitle = showFreDialogStub.lastCall.args[0].learnMoreButtonTitle;
+         const customLearnMoreButtonTitle = showFreDialogStub.lastCall.args[0].learnMoreButtonText;
          assert.exists(
              customLearnMoreButtonTitle, 'Expected FreDialog to have a custom button title but it\'s not provided');
          assert.deepEqual(customLearnMoreButtonTitle.toString(), 'Learn more');

front_end/panels/timeline/overlays/components/EntryLabelOverlay.ts

@@ -577,7 +577,7 @@ export class EntryLabelOverlay extends HTMLElement {
       onLearnMoreClick: () => {
         UI.UIUtils.openInNewTab('https://developer.chrome.com/docs/devtools/performance/annotations#auto-annotations');
       },
-      learnMoreButtonTitle: UIStringsNotTranslate.learnMoreButton,
+      learnMoreButtonText: UIStringsNotTranslate.learnMoreButton,
     });
     this.dispatchEvent(new LabelAnnotationsConsentDialogVisibilityChange(false));