[workspace_diff] Remove DevToolsImprovedWorkspaces flag.

The `DevToolsImprovedWorkspaces` flag was guarding the change in
behavior that not only all Network resources are being tracked for
changes (and therefore show up in the Changes panel), but also all
FileSystem resources that don't have a Network resource binding.

This new behavior generally makes sense, and feature-gating complicates
further development and reduces changes that bugs / problems are flushed
out early.

Bug: 393244410, 393064551
Change-Id: Ib5a39b20207faa0da46810be687d13e187fa1e8e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6342612
Auto-Submit: Benedikt Meurer <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>

Author: bmeurer

front_end/core/root/Runtime.ts

@@ -391,10 +391,6 @@ export interface HostConfigAutomaticFileSystems {
   enabled: boolean;
 }
 
-export interface HostConfigImprovedWorkspaces {
-  enabled: boolean;
-}
-
 export interface HostConfigVeLogging {
   enabled: boolean;
   testing: boolean;
@@ -452,7 +448,6 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAiAssistanceFileAgent: HostConfigAiAssistanceFileAgent,
   devToolsAiAssistancePerformanceAgent: HostConfigAiAssistancePerformanceAgent,
   devToolsAutomaticFileSystems: HostConfigAutomaticFileSystems,
-  devToolsImprovedWorkspaces: HostConfigImprovedWorkspaces,
   devToolsVeLogging: HostConfigVeLogging,
   devToolsWellKnown: HostConfigWellKnown,
   devToolsPrivacyUI: HostConfigPrivacyUI,

front_end/models/workspace_diff/BUILD.gn

@@ -13,7 +13,6 @@ devtools_module("workspace_diff") {
   deps = [
     "../../core/common:bundle",
     "../../core/host:bundle",
-    "../../core/root:bundle",
     "../../models/formatter:bundle",
     "../../models/persistence:bundle",
     "../../models/text_utils:bundle",

front_end/models/workspace_diff/WorkspaceDiff.ts

@@ -4,7 +4,6 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
-import * as Root from '../../core/root/root.js';
 import * as Diff from '../../third_party/diff/diff.js';
 import * as FormatterModule from '../formatter/formatter.js';
 import * as Persistence from '../persistence/persistence.js';
@@ -112,20 +111,18 @@ export class WorkspaceDiffImpl extends Common.ObjectWrapper.ObjectWrapper<EventT
   }
 
   #shouldTrack(uiSourceCode: Workspace.UISourceCode.UISourceCode): boolean {
-    // We track differences for all Network resources.
-    if (uiSourceCode.project().type() === Workspace.Workspace.projectTypes.Network) {
-      return true;
-    }
+    switch (uiSourceCode.project().type()) {
+      case Workspace.Workspace.projectTypes.Network:
+        // We track differences for all Network resources.
+        return true;
 
-    // Additionally we also track differences for FileSystem resources that don't have
-    // a binding (as part of the kDevToolsImprovedWorkspaces feature).
-    if (uiSourceCode.project().type() === Workspace.Workspace.projectTypes.FileSystem &&
-        this.#persistence.binding(uiSourceCode) === null &&
-        Root.Runtime.hostConfig.devToolsImprovedWorkspaces?.enabled) {
-      return true;
-    }
+      case Workspace.Workspace.projectTypes.FileSystem:
+        // We track differences for FileSystem resources without bindings.
+        return this.#persistence.binding(uiSourceCode) === null;
 
-    return false;
+      default:
+        return false;
+    }
   }
 
   private async updateModifiedState(uiSourceCode: Workspace.UISourceCode.UISourceCode): Promise<void> {

front_end/panels/changes/CombinedDiffView.test.ts

@@ -9,7 +9,7 @@ import * as Breakpoints from '../../models/breakpoints/breakpoints.js';
 import * as Persistence from '../../models/persistence/persistence.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as WorkspaceDiff from '../../models/workspace_diff/workspace_diff.js';
-import {describeWithEnvironment, updateHostConfig} from '../../testing/EnvironmentHelpers.js';
+import {describeWithEnvironment} from '../../testing/EnvironmentHelpers.js';
 import {createFileSystemUISourceCode} from '../../testing/UISourceCodeHelpers.js';
 import {createViewFunctionStub} from '../../testing/ViewFunctionHelpers.js';
 
@@ -58,8 +58,6 @@ describeWithEnvironment('CombinedDiffView', () => {
   let workspaceDiff: WorkspaceDiff.WorkspaceDiff.WorkspaceDiffImpl;
   let uiSourceCode: Workspace.UISourceCode.UISourceCode;
   beforeEach(() => {
-    // This is needed for tracking file system UI source codes.
-    updateHostConfig({devToolsImprovedWorkspaces: {enabled: true}});
     const workspace = createWorkspace();
     workspaceDiff = createWorkspaceDiff({workspace});
     ({uiSourceCode} =