Skip to content

Commit 106ff6a

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored andcommitted
RPP: try to de-flake FilmStrip test
The trace that we were using was large and has 20 screenshots, on the bots this sometimes times out. Swapped it for a much smaller trace with just 2 screenshots which is still enough to assert what we want. Bug: none Change-Id: I98d2471947af748e451138da402b4a0c055b0618 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6349185 Commit-Queue: Philip Pfaffe <[email protected]> Commit-Queue: Jack Franklin <[email protected]> Reviewed-by: Nikolay Vitkov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Auto-Submit: Jack Franklin <[email protected]>
1 parent f2b55c6 commit 106ff6a

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

front_end/models/trace/extras/FilmStrip.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ describeWithEnvironment('FilmStrip', function() {
4646

4747
describe('using the new screenshot format', () => {
4848
it('identifies the frames from a trace', async function() {
49-
const {parsedTrace} = await TraceLoader.traceEngine(this, 'web-dev-screenshot-source-ids.json.gz');
49+
const {parsedTrace} = await TraceLoader.traceEngine(this, 'example-dot-com.json.gz');
5050
const filmStrip = Trace.Extras.FilmStrip.fromParsedTrace(parsedTrace);
51-
assert.lengthOf(filmStrip.frames, 20);
51+
assert.lengthOf(filmStrip.frames, 2);
5252
});
5353

5454
it('has an array of new screenshot events', async function() {
55-
const {parsedTrace} = await TraceLoader.traceEngine(this, 'web-dev-screenshot-source-ids.json.gz');
55+
const {parsedTrace} = await TraceLoader.traceEngine(this, 'example-dot-com.json.gz');
5656
const filmStrip = Trace.Extras.FilmStrip.fromParsedTrace(parsedTrace);
5757
assert.isTrue(filmStrip.frames.every(f => Trace.Types.Events.isScreenshot(f.screenshotEvent)));
5858
});

front_end/panels/timeline/fixtures/traces/BUILD.gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ copy_to_gen("traces") {
2626
"dom-size-overlap.json.gz",
2727
"dom-size.json.gz",
2828
"enhanced-traces.json.gz",
29+
"example-dot-com.json.gz",
2930
"extension-tracks-and-marks.json.gz",
3031
"fenced-frame-fledge.json.gz",
3132
"font-display.json.gz",
Binary file not shown.

0 commit comments

Comments
 (0)