[RPP] Clean up |SyntheticCpuProfile| related code

- Update the declaration since it does not need |SyntheticBased| features.
- Add the profile |id| field so we can create one when we create the fake trace event instead of in the Samples Handler.
- Remove the |appendEvent| helper function in the SamplesIntegrator

Bug: 426512102
Change-Id: Iabf915acfda5a2a0ff349673172856596e45705d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6711332
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Paul Irish <[email protected]>

Author: Nancy Li

front_end/models/trace/handlers/SamplesHandler.ts

@@ -126,13 +126,9 @@ export function handleEvent(event: Types.Events.Event): void {
     // id and thread id are not really important, so we use the data
     // in the fake event. Should multi-thread CPU profiling be supported
     // we could use these fields in the event to pass thread info.
-    const pid = event.pid;
-    const tid = event.tid;
-    // Create an arbitrary profile id.
-    const profileId = '0x1' as Types.Events.ProfileID;
-    const profileData = getOrCreatePreProcessedData(pid, profileId);
+    const profileData = getOrCreatePreProcessedData(event.pid, event.id);
     profileData.rawProfile = event.args.data.cpuProfile;
-    profileData.threadId = tid;
+    profileData.threadId = event.tid;
     return;
   }
 

front_end/models/trace/helpers/SamplesIntegrator.ts

@@ -498,44 +498,32 @@ export class SamplesIntegrator {
 
   static createFakeTraceFromCpuProfile(profile: Protocol.Profiler.Profile, tid: Types.Events.ThreadID):
       Types.File.TraceFile {
-    const traceEvents: Types.Events.Event[] = [];
-
     if (!profile) {
-      return {traceEvents, metadata: {}};
+      return {traceEvents: [], metadata: {}};
     }
     // The |Name.CPU_PROFILE| will let MetaHandler to set |traceIsGeneric| to false
     // The start time and duration is important here because we'll use them to determine the traceBounds
     // We use the start and end time of the profile (which is longer than all samples), so the Performance
     // panel won't truncate this time period.
-    appendEvent(
-        Types.Events.Name.CPU_PROFILE, {data: {cpuProfile: profile}}, profile.startTime,
-        profile.endTime - profile.startTime, Types.Events.Phase.COMPLETE);
+    const cpuProfileEvent: Types.Events.SyntheticCpuProfile = {
+      cat: 'disabled-by-default-devtools.timeline',
+      name: Types.Events.Name.CPU_PROFILE,
+      ph: Types.Events.Phase.COMPLETE,
+      pid: Types.Events.ProcessID(1),
+      tid,
+      ts: Types.Timing.Micro(profile.startTime),
+      dur: Types.Timing.Micro(profile.endTime - profile.startTime),
+      args: {data: {cpuProfile: profile}},
+      // Create an arbitrary profile id.
+      id: '0x1' as Types.Events.ProfileID,
+    };
+
     return {
-      traceEvents,
+      traceEvents: [cpuProfileEvent],
       metadata: {
         dataOrigin: Types.File.DataOrigin.CPU_PROFILE,
       }
     };
-
-    function appendEvent(
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        name: string, args: any, ts: number, dur?: number, ph?: Types.Events.Phase, cat?: string): Types.Events.Event {
-      const event: Types.Events.Event = {
-        cat: cat || 'disabled-by-default-devtools.timeline',
-        name,
-        ph: ph || Types.Events.Phase.COMPLETE,
-        pid: Types.Events.ProcessID(1),
-        tid,
-        ts: Types.Timing.Micro(ts),
-        args,
-      };
-
-      if (dur) {
-        event.dur = Types.Timing.Micro(dur);
-      }
-      traceEvents.push(event);
-      return event;
-    }
   }
 }
 

front_end/models/trace/types/TraceEvents.ts

@@ -140,9 +140,13 @@ export interface Sample extends Event {
 /**
  * A fake trace event created to support CDP.Profiler.Profiles in the
  * trace engine.
+ *
+ * Do not extend the SyntheticBased interface because this one doesn't have a raw trace event but a raw cpu profile.
+ * Also we won't manage this event through SyntheticEventsManager.
  */
-export interface SyntheticCpuProfile extends Instant, SyntheticBased<Phase.INSTANT> {
+export interface SyntheticCpuProfile extends Complete {
   name: Name.CPU_PROFILE;
+  id: ProfileID;
   args: Args&{
     data: ArgsData & {
       cpuProfile: Protocol.Profiler.Profile,