[application] Remove ability to inspect non-attached service workers.

This seems to be effectively dead code by now, since the intended
workflow is that we auto attach to all service worker targets relevant
to the debuggee these days, and should therefore never need the ability
to open a dedicated DevTools windows to debug such a service worker (if
there's such a case, it's likely a bug that we need to fix).

Bug: 40123886
Change-Id: Ia19b3ed19f9833431ef9925974ba02e6ead910f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6695212
Reviewed-by: Danil Somsikov <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>

Author: bmeurer

front_end/core/sdk/ServiceWorkerManager.ts

@@ -221,10 +221,6 @@ export class ServiceWorkerManager extends SDKModel<EventTypes> {
     await this.#agent.invoke_stopWorker({versionId});
   }
 
-  async inspectWorker(versionId: string): Promise<void> {
-    await this.#agent.invoke_inspectWorker({versionId});
-  }
-
   workerRegistrationUpdated(registrations: Protocol.ServiceWorker.ServiceWorkerRegistration[]): void {
     for (const payload of registrations) {
       let registration = this.#registrationsInternal.get(payload.registrationId);

front_end/panels/application/ServiceWorkersView.ts

@@ -137,10 +137,6 @@ const UIStrings = {
    *@description Text in Service Workers View of the Application panel
    */
   stopString: 'Stop',
-  /**
-   *@description Text in Service Workers View of the Application panel
-   */
-  inspect: 'Inspect',
   /**
    *@description Text in Service Workers View of the Application panel
    */
@@ -585,14 +581,6 @@ export class Section {
     void this.throttler.schedule(this.update.bind(this));
   }
 
-  private targetForVersionId(versionId: string): SDK.Target.Target|null {
-    const version = this.manager.findVersion(versionId);
-    if (!version?.targetId) {
-      return null;
-    }
-    return SDK.TargetManager.TargetManager.instance().targetById(version.targetId);
-  }
-
   private addVersion(versionsStack: Element, icon: string, label: string): Element {
     const installingEntry = versionsStack.createChild('div', 'service-worker-version');
     installingEntry.createChild('div', icon);
@@ -682,12 +670,6 @@ export class Section {
         const stopButton = UI.UIUtils.createTextButton(
             i18nString(UIStrings.stopString), this.stopButtonClicked.bind(this, active.id), {jslogContext: 'stop'});
         activeEntry.appendChild(stopButton);
-        if (!this.targetForVersionId(active.id)) {
-          const inspectButton = UI.UIUtils.createTextButton(
-              i18nString(UIStrings.inspect), this.inspectButtonClicked.bind(this, active.id),
-              {jslogContext: 'inspect'});
-          activeEntry.appendChild(inspectButton);
-        }
       } else if (active.isStartable()) {
         const startButton = UI.UIUtils.createTextButton(
             i18nString(UIStrings.startString), this.startButtonClicked.bind(this), {jslogContext: 'start'});
@@ -715,14 +697,6 @@ export class Section {
         waitingEntry.createChild('div', 'service-worker-subtitle').textContent =
             i18nString(UIStrings.receivedS, {PH1: new Date(waiting.scriptResponseTime * 1000).toLocaleString()});
       }
-      if (!this.targetForVersionId(waiting.id) && (waiting.isRunning() || waiting.isStarting())) {
-        const inspectButton = UI.UIUtils.createTextButton(
-            i18nString(UIStrings.inspect), this.inspectButtonClicked.bind(this, waiting.id), {
-              title: i18nString(UIStrings.inspect),
-              jslogContext: 'waiting-entry-inspect',
-            });
-        waitingEntry.appendChild(inspectButton);
-      }
     }
     if (installing) {
       const installingEntry = this.addVersion(
@@ -733,14 +707,6 @@ export class Section {
           PH1: new Date(installing.scriptResponseTime * 1000).toLocaleString(),
         });
       }
-      if (!this.targetForVersionId(installing.id) && (installing.isRunning() || installing.isStarting())) {
-        const inspectButton = UI.UIUtils.createTextButton(
-            i18nString(UIStrings.inspect), this.inspectButtonClicked.bind(this, installing.id), {
-              title: i18nString(UIStrings.inspect),
-              jslogContext: 'installing-entry-inspect',
-            });
-        installingEntry.appendChild(inspectButton);
-      }
     }
 
     this.updateCycleView.refresh();
@@ -882,10 +848,6 @@ export class Section {
     void this.manager.stopWorker(versionId);
   }
 
-  private inspectButtonClicked(versionId: string): void {
-    void this.manager.inspectWorker(versionId);
-  }
-
   private wrapWidget(container: Element): Element {
     const shadowRoot = UI.UIUtils.createShadowRootWithCoreStyles(container, {
       cssFile: [