Skip to content

Commit 13f52f2

Browse files
bmeurerDevtools-frontend LUCI CQ
authored andcommitted
Migrate PRESUBMIT.py to use PanProjectChecks.
Fixed: 40277703 Change-Id: I64cf78b2aa1ef4b822173722f62a51ede3285818 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6718314 Auto-Submit: Benedikt Meurer <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Alex Rudenko <[email protected]>
1 parent 92caba9 commit 13f52f2

File tree

1 file changed

+11
-27
lines changed

1 file changed

+11
-27
lines changed

PRESUBMIT.py

Lines changed: 11 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,11 @@ def CheckNoUncheckedFiles(input_api, output_api):
489489

490490

491491
def _TextFilesOnlyFilter(file):
492-
"""Filters files based on prefixes and extensions that should not be treated as text files for the canned checks below."""
492+
"""Filter that yields only text files.
493+
494+
Filters files based on prefixes and extensions that should not be treated as
495+
text files for the canned checks below.
496+
"""
493497
excluded_prefixes = [
494498
'node_modules',
495499
'third_party',
@@ -508,42 +512,22 @@ def _TextFilesOnlyFilter(file):
508512
return True
509513

510514

511-
def CheckChangeHasNoStrayWhitespace(input_api, output_api):
512-
return input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
513-
input_api, output_api, source_file_filter=_TextFilesOnlyFilter)
514-
515-
516515
def CheckChangeHasNoCrAndHasOnlyOneEol(input_api, output_api):
517516
return input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol(
518517
input_api, output_api, source_file_filter=_TextFilesOnlyFilter)
519518

520519

521-
def CheckForCommitObjects(input_api, output_api):
522-
return input_api.canned_checks.CheckForCommitObjects(input_api, output_api)
523-
524-
525-
def CheckOwnersFormat(input_api, output_api):
526-
return input_api.canned_checks.CheckOwnersFormat(input_api, output_api)
527-
528-
529-
def CheckOwners(input_api, output_api):
530-
return input_api.canned_checks.CheckOwners(input_api, output_api)
531-
532-
533520
def CheckGenderNeutral(input_api, output_api):
534521
return input_api.canned_checks.CheckGenderNeutral(input_api, output_api)
535522

536523

537-
def CheckDoNotSubmitInFiles(input_api, output_api):
538-
return input_api.canned_checks.CheckDoNotSubmitInFiles(
539-
input_api, output_api)
540-
541-
542-
def CheckChangeHasDescriptionCommit(input_api, output_api):
543-
return input_api.canned_checks.CheckChangeHasDescription(
544-
input_api, output_api)
545-
546524

547525
def CheckAuthorizedAuthor(input_api, output_api):
548526
return input_api.canned_checks.CheckAuthorizedAuthor(
549527
input_api, output_api, bot_allowlist=[AUTOROLL_ACCOUNT])
528+
529+
530+
def CheckPanProjectChecksOnCommit(input_api, output_api):
531+
return input_api.canned_checks.PanProjectChecks(input_api,
532+
output_api,
533+
maxlen=120)

0 commit comments

Comments
 (0)