[cleanup] Reuse Constructor type

Bug: none
Change-Id: Ie452be4bb9f47e3166b4ccd6deacd71c13408b4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6446593
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>

Author: Lightning00Blade

front_end/core/common/Object.ts

@@ -113,7 +113,7 @@ export class ObjectWrapper<Events> implements EventTarget<Events> {
 
 // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
 export function eventMixin<Events, Base extends Platform.Constructor.Constructor<object>>(base: Base) {
-  console.assert(base !== (HTMLElement as Platform.Constructor.Constructor<object>));
+  console.assert(base !== HTMLElement);
   return class EventHandling extends base implements EventTarget<Events> {
     #events = new ObjectWrapper<Events>();
 

front_end/core/platform/Constructor.ts

@@ -2,8 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-export type Constructor<T> = new (...args: any[]) => T;
-
-export type AbstractConstructor<T> = (abstract new (...args: any[]) => T);
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export type Constructor<T, Args extends any[] = any[]> = new (...args: Args) => T;
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export type AbstractConstructor<T, Args extends any[] = any[]> = (abstract new (...args: Args) => T);
 
 export type ConstructorOrAbstract<T> = Constructor<T>|AbstractConstructor<T>;

front_end/testing/DOMHelpers.ts

@@ -9,6 +9,7 @@
  * Note that `resetTestDOM` is automatically run before each test (see `test_setup.ts`).
  **/
 
+import type * as Platform from '../core/platform/platform.js';
 import type * as NodeText from '../ui/components/node_text/node_text.js';
 import * as UI from '../ui/legacy/legacy.js';
 
@@ -88,28 +89,25 @@ export const cleanTestDOM = async () => {
   await raf();
 };
 
-interface Constructor<T> {
-  new(...args: unknown[]): T;
-}
-
 /**
  * Asserts that all emenents of `nodeList` are at least of type `T`.
  */
 export function assertElements<T extends Element>(
-    nodeList: NodeListOf<Element>, elementClass: Constructor<T>): asserts nodeList is NodeListOf<T> {
+    nodeList: NodeListOf<Element>,
+    elementClass: Platform.Constructor.Constructor<T>): asserts nodeList is NodeListOf<T> {
   nodeList.forEach(e => assert.instanceOf(e, elementClass));
 }
 
 export function getElementWithinComponent<T extends HTMLElement, V extends Element>(
-    component: T, selector: string, elementClass: Constructor<V>) {
+    component: T, selector: string, elementClass: Platform.Constructor.Constructor<V>) {
   assert.isNotNull(component.shadowRoot);
   const element = component.shadowRoot.querySelector(selector);
   assert.instanceOf(element, elementClass);
   return element;
 }
 
 export function getElementsWithinComponent<T extends HTMLElement, V extends Element>(
-    component: T, selector: string, elementClass: Constructor<V>) {
+    component: T, selector: string, elementClass: Platform.Constructor.Constructor<V>) {
   assert.isNotNull(component.shadowRoot);
   const elements = component.shadowRoot.querySelectorAll(selector);
   assertElements(elements, elementClass);

front_end/ui/legacy/RootView.ts

@@ -23,7 +23,7 @@ export class RootView extends VBox {
     }
     this.window = document.defaultView;
     this.doResize();
-    this.show((document.body as Element));
+    this.show(document.body);
   }
 
   override doResize(): void {

front_end/ui/legacy/Widget.ts

@@ -153,12 +153,8 @@ export class WidgetElement<WidgetT extends Widget&WidgetParams, WidgetParams = o
 
 customElements.define('devtools-widget', WidgetElement);
 
-interface Constructor<T, Args extends unknown[]> {
-  new(...args: Args): T;
-}
-
 export function widgetRef<T extends Widget, Args extends unknown[]>(
-    type: Constructor<T, Args>, callback: (_: T) => void): ReturnType<typeof Lit.Directives.ref> {
+    type: Platform.Constructor.Constructor<T, Args>, callback: (_: T) => void): ReturnType<typeof Lit.Directives.ref> {
   return Lit.Directives.ref((e?: Element) => {
     if (!(e instanceof HTMLElement)) {
       return;