Skip to content

Commit 16f5a6c

Browse files
OrKoNDevtools-frontend LUCI CQ
authored andcommitted
[FreestylerEval] test using UI
We now know that the hanging issue was due to code generated by the LLM hanging and therefore the workaround to use a special event was not actually helping. Bug: 362730981 Change-Id: I4f70eae7aec05812922ba1035eb8a14bf831abfc Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5832744 Commit-Queue: Alex Rudenko <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]>
1 parent 54d4d66 commit 16f5a6c

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

front_end/panels/freestyler/FreestylerAgent.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import {
1919
type ContextResponse,
2020
ConversationContext,
2121
debugLog,
22-
isDebugMode,
2322
type ParsedResponse,
2423
type RequestOptions,
2524
ResponseType,
@@ -610,10 +609,6 @@ export class FreestylerAgent extends AiAgent<SDK.DOMModel.DOMNode> {
610609
}
611610

612611
const sideEffectConfirmationPromiseWithResolvers = this.#confirmSideEffect<boolean>();
613-
if (isDebugMode()) {
614-
window.dispatchEvent(new CustomEvent(
615-
'freestylersideeffect', {detail: {confirm: sideEffectConfirmationPromiseWithResolvers.resolve}}));
616-
}
617612

618613
yield {
619614
type: ResponseType.SIDE_EFFECT,

scripts/freestyler/auto_freestyler.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,17 @@ class Example {
264264

265265
await this.#devtoolsPage.locator('aria/Ask a question about the selected element').fill(query);
266266

267-
this.#devtoolsPage.evaluate(() => {
268-
window.addEventListener('freestylersideeffect', ev => {
269-
ev.detail.confirm();
270-
});
267+
const abort = new AbortController();
268+
const autoAcceptEvals = async signal => {
269+
while (!signal.aborted) {
270+
await this.#devtoolsPage.locator('aria/Continue').click({signal});
271+
}
272+
};
273+
autoAcceptEvals(abort.signal).catch(err => {
274+
if (err.message === 'This operation was aborted') {
275+
return;
276+
}
277+
console.error('autoAcceptEvals', err);
271278
});
272279

273280
const done = this.#devtoolsPage.evaluate(() => {
@@ -282,6 +289,7 @@ class Example {
282289

283290
await this.#devtoolsPage.keyboard.press('Enter');
284291
await done;
292+
abort.abort();
285293

286294
const result = JSON.parse(await this.#devtoolsPage.evaluate(() => {
287295
return localStorage.getItem('freestylerStructuredLog');

0 commit comments

Comments
 (0)