Update TypeScript to v5.7.3

https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/
Some changes to the ArrayBuffer types was needed. And TypeScript started
"panicking" if we included a bundle multiple times, so updated the
BUILD.gn files.

Bug: none
Change-Id: I3277c191c83ea773ef88765ff89a4f4103b5757c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6210862
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/core/common/Base64.test.ts

@@ -30,12 +30,12 @@ describe('Base64 decoder', () => {
 describe('Base64 encoder', () => {
   it('encodes ArrayBuffers correctly', async () => {
     const buffer1 = new Uint8Array([0]);
-    assert.strictEqual(await Common.Base64.encode(buffer1), 'AA==');
+    assert.strictEqual(await Common.Base64.encode(buffer1.buffer), 'AA==');
 
     const buffer2 = new Uint8Array([0, 1]);
-    assert.strictEqual(await Common.Base64.encode(buffer2), 'AAE=');
+    assert.strictEqual(await Common.Base64.encode(buffer2.buffer), 'AAE=');
 
     const buffer3 = new Uint8Array([0, 1, 2]);
-    assert.strictEqual(await Common.Base64.encode(buffer3), 'AAEC');
+    assert.strictEqual(await Common.Base64.encode(buffer3.buffer), 'AAEC');
   });
 });

front_end/entrypoints/wasmparser_worker/WasmParserWorker.ts

@@ -54,7 +54,7 @@ export function dissambleWASM(
     const offsets = [];
     const functionBodyOffsets = [];
     let chunkSize: number = 128 * 1024;
-    let buffer: Uint8Array = new Uint8Array(chunkSize);
+    let buffer = new Uint8Array(chunkSize);
     let pendingSize = 0;
     let offsetInModule = 0;
     for (let i = 0; i < data.length;) {

front_end/models/bindings/FileUtils.ts

@@ -55,7 +55,7 @@ export class ChunkedFileReader implements ChunkedReader {
   #file: File|null;
   readonly #fileSizeInternal: number;
   #loadedSizeInternal: number;
-  #streamReader: ReadableStreamDefaultReader<Uint8Array>|null;
+  #streamReader: ReadableStreamDefaultReader<Uint8Array<ArrayBuffer>>|null;
   readonly #chunkSize: number;
   readonly #chunkTransferredCallback: ((arg0: ChunkedReader) => void)|undefined;
   readonly #decoder: TextDecoder;

front_end/models/persistence/PersistenceAction.test.ts

@@ -70,8 +70,10 @@ describeWithLocale('ContextMenuProvider', () => {
     uiSourceCode.project.returns(stubProject);
     const stubWorkspaceBinding = sinon.createStubInstance(Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding);
     sinon.stub(Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding, 'instance').returns(stubWorkspaceBinding);
-    const stubWasmScript = sinon.createStubInstance(
-        SDK.Script.Script, {getWasmBytecode: Promise.resolve(new Uint8Array([1, 2, 3, 4])), isWasm: true});
+    const stubWasmScript = sinon.createStubInstance(SDK.Script.Script, {
+      getWasmBytecode: Promise.resolve(new Uint8Array([1, 2, 3, 4]).buffer),
+      isWasm: true,
+    });
     stubWorkspaceBinding.scriptsForUISourceCode.returns([stubWasmScript]);
 
     menuProvider.appendApplicableItems(event, contextMenu, uiSourceCode);

front_end/panels/elements/components/BUILD.gn

@@ -56,7 +56,6 @@ devtools_module("components") {
     "../../../ui/components/buttons:bundle",
     "../../../ui/components/helpers:bundle",
     "../../../ui/components/icon_button:bundle",
-    "../../../ui/components/icon_button:bundle",
     "../../../ui/components/legacy_wrapper:bundle",
     "../../../ui/components/node_text:bundle",
     "../../../ui/components/render_coordinator:bundle",

front_end/panels/linear_memory_inspector/LinearMemoryInspectorController.test.ts

@@ -27,7 +27,7 @@ class MockRemoteObject extends SDK.RemoteObject.LocalJSONObject {
   }
 }
 
-function createWrapper(array: Uint8Array) {
+function createWrapper(array: Uint8Array<ArrayBuffer>) {
   const mockRemoteObj = new MockRemoteObject(array.buffer);
   const mockRemoteArrayBuffer = new SDK.RemoteObject.RemoteArrayBuffer(mockRemoteObj);
   return new LinearMemoryInspectorController.RemoteArrayBufferWrapper(mockRemoteArrayBuffer);

front_end/panels/linear_memory_inspector/LinearMemoryInspectorController.ts

@@ -31,7 +31,7 @@ const MEMORY_TRANSFER_MIN_CHUNK_SIZE = 1000;
 let controllerInstance: LinearMemoryInspectorController;
 
 export interface LazyUint8Array {
-  getRange(start: number, end: number): Promise<Uint8Array>;
+  getRange(start: number, end: number): Promise<Uint8Array<ArrayBuffer>>;
   length(): number;
 }
 
@@ -46,7 +46,7 @@ export class RemoteArrayBufferWrapper implements LazyUint8Array {
     return this.#remoteArrayBuffer.byteLength();
   }
 
-  async getRange(start: number, end: number): Promise<Uint8Array> {
+  async getRange(start: number, end: number): Promise<Uint8Array<ArrayBuffer>> {
     const newEnd = Math.min(end, this.length());
     if (start < 0 || start > newEnd) {
       console.error(`Requesting invalid range of memory: (${start}, ${end})`);
@@ -129,7 +129,7 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
   }
 
   static async getMemoryForAddress(memoryWrapper: LazyUint8Array, address: number):
-      Promise<{memory: Uint8Array, offset: number}> {
+      Promise<{memory: Uint8Array<ArrayBuffer>, offset: number}> {
     // Provide a chunk of memory that covers the address to show and some before and after
     // as 1. the address shown is not necessarily at the beginning of a page and
     // 2. to allow for fewer memory requests.
@@ -139,7 +139,8 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
     return {memory, offset: memoryChunkStart};
   }
 
-  static async getMemoryRange(memoryWrapper: LazyUint8Array, start: number, end: number): Promise<Uint8Array> {
+  static async getMemoryRange(memoryWrapper: LazyUint8Array, start: number, end: number):
+      Promise<Uint8Array<ArrayBuffer>> {
     // Check that the requested start is within bounds.
     // If the requested end is larger than the actual
     // memory, it will be automatically capped when

front_end/panels/linear_memory_inspector/LinearMemoryInspectorPane.test.ts

@@ -16,13 +16,13 @@ function createArray() {
 
 describeWithEnvironment('LinearMemoryInspectorPane', () => {
   class Uint8Wrapper {
-    private array: Uint8Array;
+    private array: Uint8Array<ArrayBuffer>;
 
-    constructor(array: Uint8Array) {
+    constructor(array: Uint8Array<ArrayBuffer>) {
       this.array = array;
     }
 
-    getRange(start: number, end: number): Promise<Uint8Array> {
+    getRange(start: number, end: number): Promise<Uint8Array<ArrayBuffer>> {
       return Promise.resolve(this.array.slice(start, end));
     }
     length(): number {

front_end/panels/linear_memory_inspector/components/LinearMemoryInspector.ts

@@ -52,7 +52,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 // on the 1. memoryOffset (at which index this portion starts),
 // and on the 2. outerMemoryLength (length of the original Uint8Array).
 export interface LinearMemoryInspectorData {
-  memory: Uint8Array;
+  memory: Uint8Array<ArrayBuffer>;
   address: number;
   memoryOffset: number;
   outerMemoryLength: number;

front_end/panels/linear_memory_inspector/components/LinearMemoryViewer.ts

@@ -12,7 +12,7 @@ import type {HighlightInfo} from './LinearMemoryViewerUtils.js';
 const {render, html} = Lit;
 
 export interface LinearMemoryViewerData {
-  memory: Uint8Array;
+  memory: Uint8Array<ArrayBuffer>;
   address: number;
   memoryOffset: number;
   focus: boolean;