Skip to content

Commit 1823d9a

Browse files
Adriana IxbaDevtools-frontend LUCI CQ
authored andcommitted
[RPP localizer] Ajust 3p labels
remove entity since we don't use "entity" throughout the UI Bug:None Change-Id: I8f8ee602256e0f81688df576433aa507bb20ab27 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6219647 Reviewed-by: Adam Raine <[email protected]> Commit-Queue: Adriana Ixba <[email protected]> Commit-Queue: Adam Raine <[email protected]> Auto-Submit: Adriana Ixba <[email protected]>
1 parent 9e375c8 commit 1823d9a

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

front_end/panels/timeline/TimelineUIUtils.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1254,7 +1254,7 @@ describeWithMockConnection('TimelineUIUtils', function() {
12541254

12551255
const rowData = getRowDataForDetailsElement(details)[2];
12561256
assert.deepEqual(rowData, {
1257-
title: '3rd party entity',
1257+
title: 'Third party',
12581258
value: 'Google Analytics',
12591259
});
12601260
});

front_end/panels/timeline/TimelineUIUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ const UIStrings = {
513513
/**
514514
* @description Text to refer to a 3rd Party entity.
515515
*/
516-
entity: '3rd party entity',
516+
entity: 'Third party',
517517
/**
518518
* @description Label for third party table.
519519
*/

front_end/panels/timeline/components/NetworkRequestDetails.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describeWithMockConnection('NetworkRequestDetails', () => {
5454
value: 'Render blocking',
5555
},
5656
{title: 'From cache', value: 'Yes'},
57-
{title: '3rd party entity', value: 'GitHub'},
57+
{title: 'Third party', value: 'GitHub'},
5858
{title: undefined, value: durationInnerText},
5959
{
6060
title: 'Initiated by',

front_end/panels/timeline/components/NetworkRequestDetails.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ const UIStrings = {
103103
/**
104104
* @description Text to refer to a 3rd Party entity.
105105
*/
106-
entity: '3rd party entity',
106+
entity: 'Third party',
107107
};
108108
const str_ = i18n.i18n.registerUIStrings('panels/timeline/components/NetworkRequestDetails.ts', UIStrings);
109109
const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);

0 commit comments

Comments
 (0)