Skip to content

Commit 1931fb3

Browse files
ergunshDevtools-frontend LUCI CQ
authored andcommitted
Update Chrome (for Testing) PIN
Chromium pin updated to 144.0.7535.0 Roll created at https://cr-buildbucket.appspot.com/build/8697626511874938913 Bug: none Change-Id: Ic9e5f6067b27c7b552fa42da469c9f27b9e695ac Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7182919 Reviewed-by: Nikolay Vitkov <[email protected]> Owners-Override: Ergün Erdoğmuş <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]>
1 parent 55c992e commit 1931fb3

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ vars = {
4949
# Chrome version used for tests. It should be regularly updated to
5050
# match the Canary version listed here:
5151
# https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
52-
'chrome': '144.0.7534.0',
52+
'chrome': '144.0.7535.0',
5353

5454
# 'magic' text to tell depot_tools that git submodules should be accepted but
5555
# but parity with DEPS file is expected.

test/e2e/elements/adornment_test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ describe('Adornment in the Elements Tab', function() {
9797
devToolsPage);
9898
});
9999

100-
it('displays masonry adorners', async ({devToolsPage, inspectedPage}) => {
100+
// `display: masonry` changed to `display: grid-lanes`. Skipping this test to let `CfT` roll
101+
// and in a subsequent CL, I'm going to update the implementation to look for `grid-lanes`.
102+
it.skip('[crbug.com/462642478] displays masonry adorners', async ({devToolsPage, inspectedPage}) => {
101103
await inspectedPage.goToResource('elements/adornment-masonry.html');
102104
await prepareElementsTab(devToolsPage);
103105

test/e2e/elements/masonry-editor_test.ts

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,18 @@ describe('Masonry Editor', function() {
3131
await waitForCSSPropertyValue('#target', 'display', 'masonry', undefined, devToolsPage);
3232
}
3333

34-
it('can be opened and masonry styles can be edited', async ({devToolsPage, inspectedPage}) => {
35-
await setupStyles(devToolsPage, inspectedPage);
36-
await clickStylePropertyEditorButton('Open masonry editor', 'devtools-masonry-editor', devToolsPage);
34+
// `display: masonry` changed to `display: grid-lanes`. Skipping this test to let `CfT` roll
35+
// and in a subsequent CL, I'm going to update the implementation to look for `grid-lanes`.
36+
it.skip(
37+
'[crbug.com/462642478] can be opened and masonry styles can be edited', async ({devToolsPage, inspectedPage}) => {
38+
await setupStyles(devToolsPage, inspectedPage);
39+
await clickStylePropertyEditorButton('Open masonry editor', 'devtools-masonry-editor', devToolsPage);
3740

38-
await clickPropertyButton('[title="Add justify-items: start"]', devToolsPage);
39-
await waitForCSSPropertyValue('#target', 'justify-items', 'start', undefined, devToolsPage);
40-
await clickPropertyButton('[title="Remove justify-items: start"]', devToolsPage);
41-
await devToolsPage.waitFor('[title="Add justify-items: start"]');
42-
const property = await getCSSPropertyInRule('#target', 'justify-items', undefined, devToolsPage);
43-
assert.isUndefined(property);
44-
});
41+
await clickPropertyButton('[title="Add justify-items: start"]', devToolsPage);
42+
await waitForCSSPropertyValue('#target', 'justify-items', 'start', undefined, devToolsPage);
43+
await clickPropertyButton('[title="Remove justify-items: start"]', devToolsPage);
44+
await devToolsPage.waitFor('[title="Add justify-items: start"]');
45+
const property = await getCSSPropertyInRule('#target', 'justify-items', undefined, devToolsPage);
46+
assert.isUndefined(property);
47+
});
4548
});

0 commit comments

Comments
 (0)