Skip to content

Commit 19e7728

Browse files
yaoxiachromiumDevtools-frontend LUCI CQ
authored andcommitted
[AdTagging] Frontend: Rename "Highlight ad frames" to "Highlight ads"
Ad-tagging coverage has expanded beyond frame elements to include <img> tags and elements with `background-image`. This CL updates the frontend string to reflect this broader scope. Screenshot: https://issues.chromium.org/u/1/action/issues/459135673/attachments/70892410?download=false Bug: 459135673 Change-Id: Ie8c29b751ae71fb92ce4747a5669960f1a6a9688 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7138718 Reviewed-by: Simon Zünd <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
1 parent e0a4abb commit 19e7728

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

front_end/entrypoints/inspector_main/RenderingOptions.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,13 @@ const UIStrings = {
6666
'Highlights elements (teal) that can slow down scrolling, including touch & wheel event handlers and other main-thread scrolling situations.',
6767
/**
6868
* @description The name of a checkbox setting in the Rendering tool. This setting highlights the
69-
* rendering frames for ads that are found on the page.
69+
* rendering elements for ads that are found on the page.
7070
*/
71-
highlightAdFrames: 'Highlight ad frames',
71+
highlightAds: 'Highlight ads',
7272
/**
73-
* @description Explanation text for the 'Highlight ad frames' setting in the Rendering tool.
73+
* @description Explanation text for the 'Highlight ads' setting in the Rendering tool.
7474
*/
75-
highlightsFramesRedDetectedToBe: 'Highlights frames (red) detected to be ads.',
75+
highlightsElementsRedDetectedToBe: 'Highlights elements (red) detected to be ads.',
7676
/**
7777
* @description The name of a checkbox setting in the Rendering tool. This setting prevents the
7878
* webpage from loading 'local' fonts. Local fonts are fonts that are installed on the user's
@@ -207,7 +207,7 @@ export class RenderingOptionsView extends UI.Widget.VBox {
207207
i18nString(UIStrings.scrollingPerformanceIssues), i18nString(UIStrings.highlightsElementsTealThatCan),
208208
Common.Settings.Settings.instance().moduleSetting('show-scroll-bottleneck-rects'));
209209
this.#appendCheckbox(
210-
i18nString(UIStrings.highlightAdFrames), i18nString(UIStrings.highlightsFramesRedDetectedToBe),
210+
i18nString(UIStrings.highlightAds), i18nString(UIStrings.highlightsElementsRedDetectedToBe),
211211
Common.Settings.Settings.instance().moduleSetting('show-ad-highlights'));
212212
this.#appendCheckbox(
213213
i18nString(UIStrings.disableLocalFonts), i18nString(UIStrings.disablesLocalSourcesInFontface),

0 commit comments

Comments
 (0)