AI Assistance: remove emulated function calls

Fixed: 436128886
Change-Id: I5ccb6b6f2e506391c5beab4637fe0091038ebeed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6845982
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Auto-Submit: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>

Author: OrKoN

front_end/models/ai_assistance/ConversationHandler.test.ts

@@ -143,9 +143,11 @@ describeWithMockConnection('ConversationHandler', () => {
       const conversationHandler = AiAssistanceModel.ConversationHandler.instance({
         aidaClient: mockAidaClient([
           [{
-            explanation: `ACTION
-  $0.style.backgroundColor = 'red'
-  STOP`,
+            functionCalls: [{
+              name: 'executeJavaScript',
+              args: {code: '$0.style.backgroundColor = \'red\';'},
+            }],
+            explanation: '',
           }],
         ]),
         aidaAvailability: Host.AidaClient.AidaAccessPreconditions.AVAILABLE,

front_end/models/ai_assistance/ConversationHandler.ts

@@ -23,7 +23,7 @@ import {
 import {FileAgent} from './agents/FileAgent.js';
 import {NetworkAgent, RequestContext} from './agents/NetworkAgent.js';
 import {PerformanceAgent, PerformanceTraceContext} from './agents/PerformanceAgent.js';
-import {NodeContext, StylingAgent, StylingAgentWithFunctionCalling} from './agents/StylingAgent.js';
+import {NodeContext, StylingAgent} from './agents/StylingAgent.js';
 import {
   Conversation,
   ConversationType,
@@ -71,10 +71,6 @@ const str_ = i18n.i18n.registerUIStrings('models/ai_assistance/ConversationHandl
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const lockedString = i18n.i18n.lockedString;
 
-function isAiAssistanceStylingWithFunctionCallingEnabled(): boolean {
-  return Boolean(Root.Runtime.hostConfig.devToolsFreestyler?.functionCalling);
-}
-
 function isAiAssistanceServerSideLoggingEnabled(): boolean {
   return !Root.Runtime.hostConfig.aidaAvailability?.disallowLogging;
 }
@@ -337,13 +333,6 @@ export class ConversationHandler {
           ...options,
           changeManager,
         });
-        if (isAiAssistanceStylingWithFunctionCallingEnabled()) {
-          agent = new StylingAgentWithFunctionCalling({
-            ...options,
-            changeManager,
-          });
-        }
-
         break;
       }
       case ConversationType.NETWORK: {

front_end/models/ai_assistance/agents/AiAgent.ts

@@ -243,8 +243,6 @@ export interface FunctionDeclaration<Args extends Record<string, unknown>, Retur
   }) => Promise<FunctionCallHandlerResult<ReturnType>>;
 }
 
-const OBSERVATION_PREFIX = 'OBSERVATION: ';
-
 interface AidaFetchResult {
   text?: string;
   functionCall?: Host.AidaClient.AidaFunctionCallResponse;
@@ -364,7 +362,7 @@ export abstract class AiAgent<T> {
     function validTemperature(temperature: number|undefined): number|undefined {
       return typeof temperature === 'number' && temperature >= 0 ? temperature : undefined;
     }
-    const enableAidaFunctionCalling = declarations.length && !this.functionCallEmulationEnabled;
+    const enableAidaFunctionCalling = declarations.length;
     const userTier = Host.AidaClient.convertToUserTierEnum(this.userTier);
     const preamble = userTier === Host.AidaClient.UserTier.TESTERS ? this.preamble : undefined;
     const facts = Array.from(this.#facts);
@@ -437,20 +435,6 @@ export abstract class AiAgent<T> {
     this.#functionDeclarations.clear();
   }
 
-  protected formatParsedAnswer({answer}: ParsedAnswer): string {
-    return answer;
-  }
-
-  /**
-   * Special mode for StylingAgent that turns custom text output into a
-   * function call.
-   */
-  protected functionCallEmulationEnabled = false;
-  protected emulateFunctionCall(_aidaResponse: Host.AidaClient.DoConversationResponse):
-      Host.AidaClient.AidaFunctionCallResponse|'no-function-call'|'wait-for-completion' {
-    throw new Error('Unexpected emulateFunctionCall. Only StylingAgent implements function call emulation');
-  }
-
   async *
       run(initialQuery: string, options: {
         selected: ConversationContext<T>|null,
@@ -537,7 +521,7 @@ export abstract class AiAgent<T> {
         }
         this.#history.push({
           parts: [{
-            text: this.formatParsedAnswer(parsedResponse),
+            text: parsedResponse.answer,
           }],
           role: Host.AidaClient.Role.MODEL,
         });
@@ -559,15 +543,13 @@ export abstract class AiAgent<T> {
             yield this.#createErrorResponse(ErrorType.ABORT);
             break;
           }
-          query = this.functionCallEmulationEnabled ? {text: OBSERVATION_PREFIX + result.result} : {
+          query = {
             functionResponse: {
               name: functionCall.name,
               response: result,
             },
           };
-          request = this.buildRequest(
-              query,
-              this.functionCallEmulationEnabled ? Host.AidaClient.Role.USER : Host.AidaClient.Role.ROLE_UNSPECIFIED);
+          request = this.buildRequest(query, Host.AidaClient.Role.ROLE_UNSPECIFIED);
         } catch {
           yield this.#createErrorResponse(ErrorType.UNKNOWN);
           break;
@@ -591,26 +573,15 @@ export abstract class AiAgent<T> {
     if (!call) {
       throw new Error(`Function ${name} is not found.`);
     }
-    if (this.functionCallEmulationEnabled) {
-      if (!call.displayInfoFromArgs) {
-        throw new Error('functionCallEmulationEnabled requires all functions to provide displayInfoFromArgs');
-      }
-      // Emulated function calls are formatted as text.
-      this.#history.push({
-        parts: [{text: this.#formatParsedStep(call.displayInfoFromArgs(args))}],
-        role: Host.AidaClient.Role.MODEL,
-      });
-    } else {
-      this.#history.push({
-        parts: [{
-          functionCall: {
-            name,
-            args,
-          },
-        }],
-        role: Host.AidaClient.Role.MODEL,
-      });
-    }
+    this.#history.push({
+      parts: [{
+        functionCall: {
+          name,
+          args,
+        },
+      }],
+      role: Host.AidaClient.Role.MODEL,
+    });
 
     let code;
     if (call.displayInfoFromArgs) {
@@ -723,21 +694,6 @@ export abstract class AiAgent<T> {
         break;
       }
 
-      if (this.functionCallEmulationEnabled) {
-        const emulatedFunctionCall = this.emulateFunctionCall(aidaResponse);
-        if (emulatedFunctionCall === 'wait-for-completion') {
-          continue;
-        }
-        if (emulatedFunctionCall !== 'no-function-call') {
-          yield {
-            rpcId,
-            functionCall: emulatedFunctionCall,
-            completed: true,
-          };
-          break;
-        }
-      }
-
       rpcId = aidaResponse.metadata.rpcGlobalId ?? rpcId;
       yield {
         rpcId,
@@ -759,23 +715,6 @@ export abstract class AiAgent<T> {
     }
   }
 
-  #formatParsedStep(step: ParsedStep): string {
-    let text = '';
-    if (step.thought) {
-      text = `THOUGHT: ${step.thought}`;
-    }
-    if (step.title) {
-      text += `\nTITLE: ${step.title}`;
-    }
-    if (step.action) {
-      text += `\nACTION
-${step.action}
-STOP`;
-    }
-
-    return text;
-  }
-
   #removeLastRunParts(): void {
     this.#history.splice(this.#history.findLastIndex(item => {
       return item.role === Host.AidaClient.Role.USER;