Skip to content

Commit 1b4aa4c

Browse files
ergunshDevtools-frontend LUCI CQ
authored andcommitted
[PatchWidget] Use a div for rendering saved-to-disk state
We need to use a non-interactive element for the status state. Fixed: 406080319 Change-Id: I4d3659e710d2f351cefc06fc0398af7772ee6364 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6440432 Commit-Queue: Ergün Erdoğmuş <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Alex Rudenko <[email protected]> Auto-Submit: Ergün Erdoğmuş <[email protected]>
1 parent 3fb8c84 commit 1b4aa4c

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

front_end/panels/ai_assistance/PatchWidget.ts

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ import * as PanelCommon from '../common/common.js';
2626

2727
import {SelectWorkspaceDialog} from './SelectWorkspaceDialog.js';
2828

29-
const {classMap} = Directives;
30-
3129
/*
3230
* Strings that don't need to be translated at this time.
3331
*/
@@ -383,22 +381,26 @@ export class PatchWidget extends UI.Widget.Widget {
383381
</div>`;
384382
}
385383

386-
render(
387-
html`
388-
<details class=${classMap({
389-
'change-summary': true,
390-
'saved-to-disk': Boolean(input.savedToDisk)
391-
})}>
392-
<summary>
384+
// Use a simple div for the "Saved to disk" state as it's not expandable,
385+
// otherwise use the interactive <details> element.
386+
const template = input.savedToDisk
387+
? html`
388+
<div class="change-summary saved-to-disk" role="status" aria-live="polite">
389+
<div class="header-container">
390+
${renderHeader()}
391+
</div>
392+
</div>`
393+
: html`
394+
<details class="change-summary">
395+
<summary class="header-container">
393396
${renderHeader()}
394397
</summary>
395398
${renderContent()}
396399
${renderFooter()}
397400
</details>
398-
`,
399-
target,
400-
{host: target}
401-
);
401+
`;
402+
403+
render(template, target, {host: target});
402404
});
403405
// clang-format on
404406
this.requestUpdate();

front_end/panels/ai_assistance/components/chatView.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -763,7 +763,7 @@ main {
763763
pointer-events: none;
764764
}
765765

766-
summary {
766+
& .header-container {
767767
display: flex;
768768
align-items: center;
769769
gap: var(--sys-size-3);
@@ -807,7 +807,7 @@ main {
807807
}
808808
}
809809

810-
&:not(&[open]):hover::after {
810+
&:not(.saved-to-disk, &[open]):hover::after {
811811
content: '';
812812
height: 100%;
813813
width: 100%;

0 commit comments

Comments
 (0)