Remove flaky test

There is little value in checking performance difference
on the DevTools level.

Fixed: 349787448
Change-Id: I065e908714f727aafa56a3ee4f5aed56d43bd04c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6616820
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Auto-Submit: Alex Rudenko <[email protected]>

Author: OrKoN

test/e2e/helpers/performance-helpers.ts

@@ -11,7 +11,6 @@ import {
   click,
   waitFor,
   waitForAria,
-  waitForElementWithTextContent,
   waitForFunction,
   waitForMany,
 } from '../../shared/helper.js';
@@ -357,28 +356,6 @@ export async function enableCSSSelectorStats(devToolsPage: DevToolsPage = getBro
       devToolsPage);
 }
 
-export async function disableCSSSelectorStats() {
-  const timelineSettingsPane = await waitFor(TIMELINE_SETTINGS_PANE);
-  if (await timelineSettingsPane.isHidden()) {
-    await openCaptureSettings(TIMELINE_SETTINGS_PANE);
-  }
-
-  // Wait for the checkbox to load
-  const toggle =
-      await waitForElementWithTextContent(CSS_SELECTOR_STATS_TITLE) as puppeteer.ElementHandle<HTMLInputElement>;
-  await waitForFunction(() => toggle.evaluate((e: HTMLInputElement) => {
-    if (e.disabled) {
-      return false;
-    }
-    if (e.checked) {
-      e.click();
-    }
-    return true;
-  }));
-  await expectVeEvents(
-      [veChange('Panel: timeline > Pane: timeline-settings-pane > Toggle: timeline-capture-selector-stats')]);
-}
-
 export function veImpressionForPerformancePanel() {
   return veImpression('Panel', 'timeline', [
     veImpression(

test/e2e/performance/selector-stats-tracing_test.ts

@@ -5,22 +5,17 @@
 import {assert} from 'chai';
 
 import {getBrowserAndPages, step} from '../../shared/helper.js';
-import {reloadDevTools} from '../helpers/cross-tool-helper.js';
 import {getDataGridRows} from '../helpers/datagrid-helpers.js';
 import {
-  disableCSSSelectorStats,
   enableCSSSelectorStats,
-  getRenderingTimeFromSummary,
   navigateToPerformanceTab,
   navigateToSelectorStatsTab,
-  reloadAndRecord,
   selectRecalculateStylesEvent,
   startRecording,
   stopRecording,
 } from '../helpers/performance-helpers.js';
 
-// Flaky
-describe.skip('[crbug.com/414579835] The Performance panel', function() {
+describe('The Performance panel', function() {
   // These tests move between panels, which takes time.
   if (this.timeout() !== 0) {
     this.timeout(30000);
@@ -53,25 +48,4 @@ describe.skip('[crbug.com/414579835] The Performance panel', function() {
       assert.isAtLeast(rows.length, 1, 'Selector stats table should contain at least one row');
     });
   });
-
-  // Flaking on multiple bots on CQ.
-  it.skip('[crbug.com/349787448] CSS selector stats performance test', async () => {
-    // set a tentative threshold of 50%
-    const timeDiffPercentageMax = 0.5;
-
-    await navigateToPerformanceTab('selectorStats/page-with-style-perf-test');
-    await disableCSSSelectorStats();
-    await reloadAndRecord();
-    const [recordingTimeWithSelectorStatsDisabled, chartName] = await getRenderingTimeFromSummary();
-    assert.strictEqual(chartName, 'Rendering');
-
-    await reloadDevTools({selectedPanel: {name: 'timeline'}});
-    await enableCSSSelectorStats();
-    await reloadAndRecord();
-    const [recordingTimeWithSelectorStatsEnabled] = await getRenderingTimeFromSummary();
-
-    const timeDiffPercentage = (recordingTimeWithSelectorStatsEnabled - recordingTimeWithSelectorStatsDisabled) /
-        recordingTimeWithSelectorStatsDisabled;
-    assert.isAtMost(timeDiffPercentage, timeDiffPercentageMax);
-  });
 });