[AI Assistance] Remove prototype integration with Sources

Bug: 393267670
Change-Id: I1bafb457fb109544caf3907c3ef9930a91ee9ac6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6233109
Reviewed-by: Nikolay Vitkov <[email protected]>
Auto-Submit: Alex Rudenko <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>

Author: OrKoN

front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -9,7 +9,6 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
-import * as Persistence from '../../models/persistence/persistence.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Lit from '../../ui/lit/lit.js';
@@ -38,7 +37,6 @@ import {
   NetworkAgent,
   RequestContext,
 } from './agents/NetworkAgent.js';
-import {PatchAgent, ProjectContext} from './agents/PatchAgent.js';
 import {CallTreeContext, PerformanceAgent} from './agents/PerformanceAgent.js';
 import {NodeContext, StylingAgent, StylingAgentWithFunctionCalling} from './agents/StylingAgent.js';
 import aiAssistancePanelStyles from './aiAssistancePanel.css.js';
@@ -163,13 +161,6 @@ function createFileContext(file: Workspace.UISourceCode.UISourceCode|null): File
   return new FileContext(file);
 }
 
-function createProjectContext(project: Persistence.FileSystemWorkspaceBinding.FileSystem|null): ProjectContext|null {
-  if (!project) {
-    return null;
-  }
-  return new ProjectContext(project);
-}
-
 function createRequestContext(request: SDK.NetworkRequest.NetworkRequest|null): RequestContext|null {
   if (!request) {
     return null;
@@ -209,7 +200,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   #currentAgent?: AiAgent<unknown>;
 
   #previousSameOriginContext?: ConversationContext<unknown>;
-  #project: ProjectContext|null = null;
   #selectedFile: FileContext|null = null;
   #selectedElement: NodeContext|null = null;
   #selectedCallTree: CallTreeContext|null = null;
@@ -356,8 +346,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         break;
       }
       case AgentType.PATCH: {
-        agent = new PatchAgent(options);
-        break;
+        throw new Error('AI Assistance does not support direct usage of the patch agent');
       }
     }
 
@@ -451,8 +440,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     this.#selectedCallTree =
         createCallTreeContext(UI.Context.Context.instance().flavor(TimelineUtils.AICallTree.AICallTree)),
     this.#selectedFile = createFileContext(UI.Context.Context.instance().flavor(Workspace.UISourceCode.UISourceCode)),
-    this.#project =
-        createProjectContext(UI.Context.Context.instance().flavor(Persistence.FileSystemWorkspaceBinding.FileSystem)),
     this.#viewProps = {
       ...this.#viewProps,
       agentType: this.#currentAgent?.type,
@@ -473,8 +460,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         TimelineUtils.AICallTree.AICallTree, this.#handleTraceEntryNodeFlavorChange);
     UI.Context.Context.instance().addFlavorChangeListener(
         Workspace.UISourceCode.UISourceCode, this.#handleUISourceCodeFlavorChange);
-    UI.Context.Context.instance().addFlavorChangeListener(
-        Persistence.FileSystemWorkspaceBinding.FileSystem, this.#handlePersistenceFileSystemChange);
     UI.Context.Context.instance().addFlavorChangeListener(
         ElementsPanel.ElementsPanel.ElementsPanel, this.#selectDefaultAgentIfNeeded, this);
     UI.Context.Context.instance().addFlavorChangeListener(
@@ -600,19 +585,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         this.#updateAgentState(this.#currentAgent);
       };
 
-  #handlePersistenceFileSystemChange =
-      (ev: Common.EventTarget.EventTargetEvent<Persistence.FileSystemWorkspaceBinding.FileSystem>): void => {
-        const newProject = ev.data;
-        if (!newProject) {
-          return;
-        }
-        if (this.#project?.getItem() === newProject) {
-          return;
-        }
-        this.#project = new ProjectContext(ev.data as Workspace.Workspace.Project);
-        this.#updateAgentState(this.#currentAgent);
-      };
-
   #handleAiAssistanceEnabledSettingChanged = (): void => {
     const nextChatUiState = this.#getChatUiState();
     if (this.#viewProps.state === nextChatUiState) {
@@ -674,11 +646,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
     let targetAgentType: AgentType|undefined;
     switch (actionId) {
-      case 'ai-assistance.filesystem': {
-        // TODO: metrics if needed.
-        targetAgentType = AgentType.PATCH;
-        break;
-      }
       case 'freestyler.elements-floating-button': {
         Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceOpenedFromElementsPanelFloatingButton);
         targetAgentType = AgentType.STYLING;
@@ -856,8 +823,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         context = this.#selectedCallTree;
         break;
       case AgentType.PATCH:
-        context = this.#project;
-        break;
+        throw new Error('AI Assistance does not support direct usage of the patch agent');
     }
     return context;
   }
@@ -1035,8 +1001,7 @@ export class ActionDelegate implements UI.ActionRegistration.ActionDelegate {
       case 'drjones.network-panel-context':
       case 'drjones.performance-panel-context':
       case 'drjones.sources-floating-button':
-      case 'drjones.sources-panel-context':
-      case 'ai-assistance.filesystem': {
+      case 'drjones.sources-panel-context': {
         void (async () => {
           const view = UI.ViewManager.ViewManager.instance().view(
               AiAssistancePanel.panelName,

front_end/panels/ai_assistance/agents/PatchAgent.ts

@@ -26,7 +26,7 @@ Use those functions to fulfill the user query.
 ## Step-by-step instructions
 
 - Think about what the user wants.
-- List all files in the project.
+- List all files in the project or search for relevant files.
 - Identify the files that are likely to be modified.
 - Retrieve the content of those files.
 - Rewrite the files according to the user query.
@@ -37,6 +37,19 @@ Use those functions to fulfill the user query.
 - Always prefer changing the true source files and not the build output.
 - The build output is usually in dist/, out/, build/ folders.
 - *CRITICAL* never make the same function call twice.
+- *CRITICAL* do not make any changes if not prompted.
+
+Instead of using the writeFile function you can also produce  the following diff format:
+
+\`\`\`
+src/index.html
+<meta charset="utf-8">
+<title>Test</title>
+\`\`\`
+
+First output the filename (example, src/index.html), then output the SEARCH block,
+followed by the REPLACE block.
+
 `;
 /* clang-format on */
 
@@ -134,6 +147,82 @@ export class PatchAgent extends AiAgent<Workspace.Workspace.Project> {
       },
     });
 
+    this.declareFunction<{
+      query: string,
+      caseSensitive: boolean,
+      isRegex: boolean,
+    }>('searchInFiles', {
+      description:
+          'Searches for a query in all files in the project. For each match it returns the positions of matches.',
+      parameters: {
+        type: Host.AidaClient.ParametersTypes.OBJECT,
+        description: '',
+        nullable: false,
+        properties: {
+          query: {
+            type: Host.AidaClient.ParametersTypes.STRING,
+            description: 'The query to search for matches in files',
+            nullable: false,
+          },
+          caseSensitive: {
+            type: Host.AidaClient.ParametersTypes.BOOLEAN,
+            description: 'Whether the query is case sensitive or not',
+            nullable: false,
+          },
+          isRegex: {
+            type: Host.AidaClient.ParametersTypes.BOOLEAN,
+            description: 'Whether the query is a regular expression or not',
+            nullable: true,
+          }
+        },
+      },
+      handler: async params => {
+        if (!this.#project) {
+          return {
+            error: 'No project available',
+          };
+        }
+        const project = this.#project.getItem();
+        const {map} = getFiles(project);
+        const matches = [];
+        for (const [filepath, file] of map.entries()) {
+          const results = await project.searchInFileContent(file, params.query, params.caseSensitive, params.isRegex);
+          for (const result of results) {
+            matches.push({
+              filepath,
+              lineNumber: result.lineNumber,
+              columnNumber: result.columnNumber,
+              matchLength: result.matchLength
+            });
+          }
+        }
+        return {
+          result: {
+            matches,
+          }
+        };
+      },
+    });
+
+    this.declareFunction('changeFile', {
+      description: 'returns a list of all files in the project.',
+      parameters: {
+        type: Host.AidaClient.ParametersTypes.OBJECT,
+        description: '',
+        nullable: true,
+        properties: {
+          filepath: {
+            type: Host.AidaClient.ParametersTypes.STRING,
+            description: 'A file path that identifies the file to get the content for',
+            nullable: false,
+          },
+        },
+      },
+      handler: async () => {
+        return {result: {}};
+      },
+    });
+
     this.declareFunction<{filepath: string}>('readFile', {
       description: 'returns the complement content of a file',
       parameters: {

front_end/panels/ai_assistance/ai_assistance-meta.ts

@@ -236,20 +236,6 @@ UI.ActionRegistration.registerActionExtension({
   condition: config => isFileAgentFeatureAvailable(config) && !isPolicyRestricted(config),
 });
 
-UI.ActionRegistration.registerActionExtension({
-  actionId: 'ai-assistance.filesystem',
-  contextTypes(): [] {
-    return [];
-  },
-  category: UI.ActionRegistration.ActionCategory.GLOBAL,
-  title: i18nLazyString(UIStrings.askAi),
-  async loadActionDelegate() {
-    const AiAssistance = await loadAiAssistanceModule();
-    return new AiAssistance.ActionDelegate();
-  },
-  condition: _config => Boolean(window.localStorage.getItem('ai_assistance_experimental_patch_do_not_use')),
-});
-
 UI.ActionRegistration.registerActionExtension({
   actionId: 'drjones.sources-panel-context',
   contextTypes() {

front_end/panels/sources/NavigatorView.ts

@@ -1122,13 +1122,6 @@ export class NavigatorView extends UI.Widget.VBox implements SDK.TargetManager.O
               project.remove();
             }
           }, {jslogContext: 'remove-folder-from-workspace'});
-
-          if (UI.ActionRegistry.ActionRegistry.instance().hasAction('ai-assistance.filesystem')) {
-            contextMenu.headerSection().appendAction(
-                'ai-assistance.filesystem',
-            );
-            UI.Context.Context.instance().setFlavor(Persistence.FileSystemWorkspaceBinding.FileSystem, project);
-          }
         }
       } else {
         if (!(node instanceof NavigatorGroupTreeNode)) {

front_end/ui/visual_logging/KnownContextValues.ts

@@ -335,7 +335,6 @@ export const knownContextValues = new Set([
   'affected-sources',
   'ai-assistance-enabled',
   'ai-assistance-history-entries',
-  'ai-assistance.filesystem',
   'ai_assistance',
   'align-content',
   'align-content-center',