Skip to content

Commit 1e8dfb5

Browse files
ElormCochDevtools-frontend LUCI CQ
authored andcommitted
Add aria-label to renderIconLink for improved accessibility
Repro steps: 1. Open Chrome devtools 2. Navigate to the Application tab and turn on Narrator 3. Navigate to the Frames -> Top page 4. Observe an issue that when focus lands to the 'Click to Open in Sources Panel' button the screen reader announces it as only Button and does not announce the name or label for it. Actual Result: Screen reader does not announce the name information for the 'Click to Open in Sources Panel' button. Observation: Screen reader is just announcing it as button Expected Result: A proper name should be defined for 'Click to Open in Sources Panel' button. Bug: 448699366 Change-Id: Ie1e33c7c8655a8a10ab8cc64164af0b6edcd54a4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7004565 Commit-Queue: Sylvester Elorm Coch <[email protected]> Reviewed-by: Simon Zünd <[email protected]>
1 parent 03381b3 commit 1e8dfb5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

front_end/panels/application/components/PermissionsPolicySection.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ export function renderIconLink(
7979
<devtools-button
8080
.iconName=${iconName}
8181
title=${title}
82+
aria-label=${title}
8283
.variant=${Buttons.Button.Variant.ICON}
8384
.size=${Buttons.Button.Size.SMALL}
8485
@click=${clickHandler}

0 commit comments

Comments
 (0)