Skip to content

Commit 1fdda7b

Browse files
Samiya CaurDevtools-frontend LUCI CQ
authored andcommitted
[AiAssistance] Add ability to open image (sent as input) in a new tab
Bug:393036589 Change-Id: I17ba0674b6636028bdfd8845a78ceb5741372b89 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6262088 Commit-Queue: Samiya Caur <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]>
1 parent 74cbb8a commit 1fdda7b

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

front_end/panels/ai_assistance/components/ChatView.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,10 @@ const UIStringsNotTranslate = {
284284
*@description Alt text for the account avatar.
285285
*/
286286
accountAvatar: 'Account avatar',
287+
/**
288+
*@description Title for the x-link which wraps the image input rendered in chat messages.
289+
*/
290+
openImageInNewTab: 'Open image in a new tab',
287291
};
288292

289293
const str_ = i18n.i18n.registerUIStrings('panels/ai_assistance/components/ChatView.ts', UIStrings);
@@ -1116,7 +1120,14 @@ function renderChatMessage({
11161120
let imageInput = html``;
11171121
if (message.imageInput && 'inlineData' in message.imageInput) {
11181122
const imageUrl = `data:image/jpeg;base64,${message.imageInput.inlineData.data}`;
1119-
imageInput = html`<img src=${imageUrl} alt=${UIStringsNotTranslate.imageInputSentToTheModel} />`;
1123+
// clang-format off
1124+
imageInput = html`<x-link
1125+
class="image-link" title=${UIStringsNotTranslate.openImageInNewTab}
1126+
href=${imageUrl}
1127+
>
1128+
<img src=${imageUrl} alt=${UIStringsNotTranslate.imageInputSentToTheModel} />
1129+
</x-link>`;
1130+
// clang-format on
11201131
}
11211132
// clang-format off
11221133
return html`<section

front_end/panels/ai_assistance/components/chatView.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,10 @@
291291
border: 1px solid var(--sys-color-neutral-outline);
292292
width: fit-content;
293293
}
294+
295+
.image-link {
296+
width: fit-content;
297+
}
294298
}
295299

296300
.select-element {

0 commit comments

Comments
 (0)