Skip to content

Commit 209adee

Browse files
bmeurerDevtools-frontend LUCI CQ
authored andcommitted
[network] Fix typo in export HAR bindings code.
For some reason, tsc didn't catch this last minute refactoring typo, which results in the wrong `this` being passed to `exportAll`, and causes the HAR export button and menu items to stop functioning correctly in M-130 and beyond. Fixed: 372055502 Bug: 361717594 Change-Id: Iad45a68821ee516e152df76e736c1479f152b9c3 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5934214 Auto-Submit: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]> Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Yang Guo <[email protected]>
1 parent bfbf5cf commit 209adee

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

front_end/panels/network/NetworkPanel.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ export class NetworkPanel extends UI.Panel.Panel implements
471471
new UI.Toolbar.ToolbarButton(i18nString(UIStrings.exportHarSanitized), 'download', undefined, 'export-har');
472472
exportHarButton.addEventListener(
473473
UI.Toolbar.ToolbarButton.Events.CLICK,
474-
this.networkLogView.exportAll.bind(this.networkItemView, {sanitize: true}), this);
474+
this.networkLogView.exportAll.bind(this.networkLogView, {sanitize: true}), this);
475475
this.panelToolbar.appendToolbarItem(exportHarButton);
476476

477477
// Support for exporting HAR (with sensitive data), which is added via a long-click
@@ -491,12 +491,12 @@ export class NetworkPanel extends UI.Panel.Panel implements
491491
const contextMenu = new UI.ContextMenu.ContextMenu(event);
492492
contextMenu.defaultSection().appendItem(
493493
i18nString(UIStrings.exportHarSanitized),
494-
this.networkLogView.exportAll.bind(this.networkItemView, {sanitize: true}),
494+
this.networkLogView.exportAll.bind(this.networkLogView, {sanitize: true}),
495495
{jslogContext: 'export-har'},
496496
);
497497
contextMenu.defaultSection().appendItem(
498498
i18nString(UIStrings.exportHarWithSensitiveData),
499-
this.networkLogView.exportAll.bind(this.networkItemView, {sanitize: false}),
499+
this.networkLogView.exportAll.bind(this.networkLogView, {sanitize: false}),
500500
{jslogContext: 'export-har-with-sensitive-data'},
501501
);
502502
void contextMenu.show();

0 commit comments

Comments
 (0)