Skip to content

Commit 21e2d7c

Browse files
paulirishDevtools-frontend LUCI CQ
authored andcommitted
RPP: Memory, JS sampling, 3P dim checkboxes should reset after session
These settings should reset to default after DevTools is closed. The memory item in particular steals a lot of screen space and users rarely turn it off despite not needing it. Bug: 40272810 Change-Id: Ied61cbecfa5b5721a8268ffc9dcc157e144f9b2a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6287749 Commit-Queue: Paul Irish <[email protected]> Auto-Submit: Paul Irish <[email protected]> Commit-Queue: Adriana Ixba <[email protected]> Reviewed-by: Adriana Ixba <[email protected]>
1 parent 7f2052f commit 21e2d7c

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

front_end/panels/timeline/TimelinePanel.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -530,8 +530,8 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
530530

531531
this.traceLoadStart = null;
532532

533-
this.disableCaptureJSProfileSetting =
534-
Common.Settings.Settings.instance().createSetting('timeline-disable-js-sampling', false);
533+
this.disableCaptureJSProfileSetting = Common.Settings.Settings.instance().createSetting(
534+
'timeline-disable-js-sampling', false, Common.Settings.SettingStorageType.SESSION);
535535
this.disableCaptureJSProfileSetting.setTitle(i18nString(UIStrings.disableJavascriptSamples));
536536
this.captureLayersAndPicturesSetting = Common.Settings.Settings.instance().createSetting(
537537
'timeline-capture-layers-and-pictures', false, Common.Settings.SettingStorageType.SESSION);
@@ -545,12 +545,13 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
545545
this.showScreenshotsSetting.setTitle(i18nString(UIStrings.screenshots));
546546
this.showScreenshotsSetting.addChangeListener(this.updateMiniMap, this);
547547

548-
this.showMemorySetting = Common.Settings.Settings.instance().createSetting('timeline-show-memory', false);
548+
this.showMemorySetting = Common.Settings.Settings.instance().createSetting(
549+
'timeline-show-memory', false, Common.Settings.SettingStorageType.SESSION);
549550
this.showMemorySetting.setTitle(i18nString(UIStrings.memory));
550551
this.showMemorySetting.addChangeListener(this.onMemoryModeChanged, this);
551552

552-
this.#dimThirdPartiesSetting =
553-
Common.Settings.Settings.instance().createSetting('timeline-dim-third-parties', false);
553+
this.#dimThirdPartiesSetting = Common.Settings.Settings.instance().createSetting(
554+
'timeline-dim-third-parties', false, Common.Settings.SettingStorageType.SESSION);
554555
this.#dimThirdPartiesSetting.setTitle(i18nString(UIStrings.dimThirdParties));
555556
this.#dimThirdPartiesSetting.addChangeListener(this.onDimThirdPartiesChanged, this);
556557

0 commit comments

Comments
 (0)