[Freestyler] Move response instrumentation to AiAgent

The `run` function is being used to render previous conversations
as well and we don't want to capture the metrics for
rendering those conversations but capture
only for the active conversation.

Bug: 374667861
Change-Id: I20cff986ac73b88c302619709e6e6ad1712aa45c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5966674
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>

Author: ergunsh

front_end/panels/freestyler/AiAgent.ts

@@ -390,6 +390,7 @@ STOP`;
           error: ErrorType.UNKNOWN,
           rpcId,
         } as const;
+        Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceError);
         this.#addHistory(id, response);
         yield response;
 
@@ -410,6 +411,7 @@ STOP`;
             rpcId,
             suggestions,
           } as const;
+          Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceAnswerReceived);
           this.#addHistory(id, response);
           yield response;
         } else {
@@ -418,6 +420,7 @@ STOP`;
             error: ErrorType.UNKNOWN,
             rpcId,
           } as const;
+          Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceError);
           this.#addHistory(id, response);
           yield response;
         }
@@ -463,6 +466,7 @@ STOP`;
           type: ResponseType.ERROR,
           error: ErrorType.MAX_STEPS,
         } as const;
+        Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceError);
         this.#addHistory(id, response);
         yield response;
         break;

front_end/panels/freestyler/FreestylerAgent.ts

@@ -559,7 +559,13 @@ export class FreestylerAgent extends AiAgent<SDK.DOMModel.DOMNode> {
         yield {
           type: ResponseType.SIDE_EFFECT,
           code: action,
-          confirm: sideEffectConfirmationPromiseWithResolvers.resolve,
+          confirm: (result: boolean) => {
+            sideEffectConfirmationPromiseWithResolvers.resolve(result);
+            Host.userMetrics.actionTaken(
+                result ? Host.UserMetrics.Action.AiAssistanceSideEffectConfirmed :
+                         Host.UserMetrics.Action.AiAssistanceSideEffectRejected,
+            );
+          },
           rpcId,
         };
 

front_end/panels/freestyler/FreestylerPanel.ts

@@ -624,7 +624,6 @@ export class FreestylerPanel extends UI.Panel.Panel {
           }
           step.isLoading = false;
           this.#viewProps.isLoading = false;
-          Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceAnswerReceived);
           break;
         }
         case ResponseType.ERROR: {
@@ -641,10 +640,6 @@ export class FreestylerPanel extends UI.Panel.Panel {
               systemMessage.steps.pop();
             }
           }
-
-          if (data.error !== ErrorType.ABORT) {
-            Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceError);
-          }
         }
       }
 

front_end/panels/freestyler/components/FreestylerChatUi.ts

@@ -662,11 +662,6 @@ export class FreestylerChatUi extends HTMLElement {
       step.sideEffect?.onAnswer(answer);
       step.sideEffect = undefined;
       this.#render();
-
-      Host.userMetrics.actionTaken(
-          answer ? Host.UserMetrics.Action.AiAssistanceSideEffectConfirmed :
-                   Host.UserMetrics.Action.AiAssistanceSideEffectRejected,
-      );
     };
 
     // clang-format off