Skip to content

Commit 2357b94

Browse files
yanlingwang23Devtools-frontend LUCI CQ
authored andcommitted
[Accessibility] Update button size to meet minimum size criteria
Height and width for "Clear, Enable regular expressions & Enable case sensitive search" buttons does not meet the minimum required size of 24x24 minimum size criteria. Before: https://imgur.com/a/rKK7aaF After: https://imgur.com/a/EzanZyU Bug: 375093292 Change-Id: Ia501bd9e2948570e33b018ebd3d8f5fc8c6b5d68 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5963416 Reviewed-by: Kateryna Prokopenko <[email protected]> Reviewed-by: Peter Müller <[email protected]> Commit-Queue: Yanling Wang <[email protected]>
1 parent 716e2c6 commit 2357b94

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

front_end/panels/search/SearchView.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ function createSearchToggleButton(iconName: string, jslogContext: string): Butto
9595
const button = new Buttons.Button.Button();
9696
button.data = {
9797
variant: Buttons.Button.Variant.ICON_TOGGLE,
98-
size: Buttons.Button.Size.SMALL,
9998
iconName,
10099
toggledIconName: iconName,
101100
toggleType: Buttons.Button.ToggleType.PRIMARY,
@@ -192,7 +191,6 @@ export class SearchView extends UI.Widget.VBox {
192191
const clearInputFieldButton = new Buttons.Button.Button();
193192
clearInputFieldButton.data = {
194193
variant: Buttons.Button.Variant.ICON,
195-
size: Buttons.Button.Size.SMALL,
196194
iconName: 'cross-circle-filled',
197195
jslogContext: 'clear-input',
198196
title: i18nString(UIStrings.clearInput),

front_end/panels/search/searchView.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
flex-grow: 1;
2424
box-shadow: inset 0 0 0 2px transparent;
2525
box-sizing: border-box;
26-
height: var(--sys-size-9);
26+
height: var(--sys-size-11);
2727
margin-left: var(--sys-size-3);
2828
padding: 0 var(--sys-size-2) 0 var(--sys-size-5);
2929
border-radius: 100px;

0 commit comments

Comments
 (0)