Skip to content

Commit 23ae720

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
[e2e] Disable Network for Puppeteer
In DevTools test we never use the Request part of Puppeteer, as we don't read request or use Puppeteer network interception. This means we are paying extra cost for having the domain enabled. Testing the times for a small subset (test/e2e_non_hosted/elements/) yielded 2.5% improvements on my CloudTop. Bug: none Change-Id: Ie046db3a60ea9437460332ae31828a1a01da78c8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6787911 Reviewed-by: Alex Rudenko <[email protected]> Reviewed-by: Liviu Rau <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent bbe63c4 commit 23ae720

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/e2e_non_hosted/shared/browser-helper.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ export class Launcher {
6464
executablePath,
6565
dumpio: !headless || Boolean(process.env['LUCI_CONTEXT']),
6666
protocolTimeout,
67+
networkEnabled: false,
6768
};
6869

6970
TestConfig.configureChrome(executablePath);

0 commit comments

Comments
 (0)