[cleanup] Use import in test code

This should not be needed as I don't see anyone modifying the
puppeteer properties.

Bug: none
Change-Id: Iac871d0070b7d2c7100d422fe530f7c15f413b6e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6298972
Auto-Submit: Nikolay Vitkov <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>

Author: Lightning00Blade

test/conductor/events.ts

@@ -9,11 +9,8 @@
 
 /* eslint-disable no-console */
 
-// use require here due to
-// https://github.com/evanw/esbuild/issues/587#issuecomment-901397213
-import puppeteer = require('puppeteer-core');
-
-const path = require('path');
+import * as path from 'path';
+import type * as puppeteer from 'puppeteer-core';
 
 const ALLOWED_ASSERTION_FAILURES = [
   // Failure during shutdown. crbug.com/1145969

test/conductor/frontend_tab.ts

@@ -4,9 +4,7 @@
 
 import * as fs from 'fs';
 import * as path from 'path';
-// use require here due to
-// https://github.com/evanw/esbuild/issues/587#issuecomment-901397213
-import puppeteer = require('puppeteer-core');
+import type * as puppeteer from 'puppeteer-core';
 
 import {installPageErrorHandlers} from './events.js';
 import {BUILD_ROOT} from './paths.js';

test/conductor/hooks.ts

@@ -4,19 +4,17 @@
 
 /* eslint-disable no-console */
 
-// use require here due to
-// https://github.com/evanw/esbuild/issues/587#issuecomment-901397213
-import puppeteer = require('puppeteer-core');
+import * as puppeteer from 'puppeteer-core';
 
 import {
   dumpCollectedErrors,
   installPageErrorHandlers,
   setupBrowserProcessIO,
 } from './events.js';
 import {
+  type DevToolsFrontendReloadOptions,
   DevToolsFrontendTab,
   loadEmptyPageAndWaitForContent,
-  type DevToolsFrontendReloadOptions,
 } from './frontend_tab.js';
 import {
   clearPuppeteerState,
@@ -28,13 +26,6 @@ import {
 import {TargetTab} from './target_tab.js';
 import {TestConfig} from './test_config.js';
 
-// Workaround for mismatching versions of puppeteer types and puppeteer library.
-declare module 'puppeteer-core' {
-  interface ConsoleMessage {
-    stackTrace(): ConsoleMessageLocation[];
-  }
-}
-
 const viewportWidth = 1280;
 const viewportHeight = 720;
 // Adding some offset to the window size used in the headful mode

test/conductor/pool.ts

@@ -2,9 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// use require here due to
-// https://github.com/evanw/esbuild/issues/587#issuecomment-901397213
-import puppeteer = require('puppeteer-core');
+import type * as puppeteer from 'puppeteer-core';
 
 import {DevToolsFrontendTab} from './frontend_tab.js';
 import {TargetTab} from './target_tab.js';

test/conductor/target_tab.ts

@@ -2,9 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// use require here due to
-// https://github.com/evanw/esbuild/issues/587#issuecomment-901397213
-import puppeteer = require('puppeteer-core');
+import type * as puppeteer from 'puppeteer-core';
 
 import {loadEmptyPageAndWaitForContent} from './frontend_tab.js';