lint: rename no-widget-show-document-body > no-document-body-mutation

Bug: 421811012
Change-Id: Iaf44afa038277b09e7d45cc7a4ccfdb5b0a007a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6611008
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>

Author: jackfranklin

eslint.config.mjs

@@ -7,9 +7,9 @@ import eslintPlugin from 'eslint-plugin-eslint-plugin';
 import importPlugin from 'eslint-plugin-import';
 import jsdocPlugin from 'eslint-plugin-jsdoc';
 import mochaPlugin from 'eslint-plugin-mocha';
-import { defineConfig, globalIgnores } from 'eslint/config';
+import {defineConfig, globalIgnores} from 'eslint/config';
 import globals from 'globals';
-import { join } from 'path';
+import {join} from 'path';
 import typescriptEslint from 'typescript-eslint';
 
 import rulesdirPlugin from './scripts/eslint_rules/rules-dir.mjs';
@@ -193,7 +193,7 @@ export default defineConfig([
       radix: 'error',
       'valid-typeof': 'error',
       'no-return-assign': ['error', 'always'],
-      'no-implicit-coercion': ['error', { allow: ['!!'] }],
+      'no-implicit-coercion': ['error', {allow: ['!!']}],
 
       'no-array-constructor': 'error',
 
@@ -305,11 +305,11 @@ export default defineConfig([
       parserOptions: {
         allowAutomaticSingleRunInference: true,
         project: join(
-          import.meta.dirname,
-          'config',
-          'typescript',
-          'tsconfig.eslint.json',
-        ),
+            import.meta.dirname,
+            'config',
+            'typescript',
+            'tsconfig.eslint.json',
+            ),
       },
     },
 
@@ -554,12 +554,12 @@ export default defineConfig([
         {
           // Enforce that any import of models/trace/trace.js names the import Trace.
           modulePath: join(
-            import.meta.dirname,
-            'front_end',
-            'models',
-            'trace',
-            'trace.js',
-          ),
+              import.meta.dirname,
+              'front_end',
+              'models',
+              'trace',
+              'trace.js',
+              ),
           importName: 'Trace',
         },
       ],
@@ -704,7 +704,7 @@ export default defineConfig([
       'rulesdir/prefer-sinon-assert': 'error',
       'rulesdir/prefer-url-string': 'error',
       'rulesdir/trace-engine-test-timeouts': 'error',
-      'rulesdir/no-widget-show-document-body': 'error',
+      'rulesdir/no-document-body-mutation': 'error',
       'rulesdir/enforce-custom-element-definitions-location': 'off',
     },
 

front_end/testing/DOMHelpers.ts

@@ -79,7 +79,7 @@ export const setupTestDOM = async () => {
   const newContainer = document.createElement('div');
   newContainer.id = TEST_CONTAINER_ID;
 
-  // eslint-disable-next-line rulesdir/no-widget-show-document-body
+  // eslint-disable-next-line rulesdir/no-document-body-mutation
   document.body.appendChild(newContainer);
 };
 

scripts/eslint_rules/lib/no-widget-show-document-body.ts renamed to scripts/eslint_rules/lib/no-document-body-mutation.ts

@@ -57,7 +57,7 @@ function isDocumentBodyMethodCallToAddDOM(node: TSESTree.Node): node is TSESTree
 }
 
 export default createRule({
-  name: 'no-widget-show-document-body',
+  name: 'no-document-body-mutation',
   meta: {
     type: 'problem',
 

scripts/eslint_rules/tests/no-widget-show-document-body.test.ts renamed to scripts/eslint_rules/tests/no-document-body-mutation.test.ts

@@ -1,11 +1,11 @@
 // Copyright 2020 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-import rule from '../lib/no-widget-show-document-body.ts';
+import rule from '../lib/no-document-body-mutation.ts';
 
 import {RuleTester} from './utils/RuleTester.ts';
 
-new RuleTester().run('no-widget-show-document-body', rule, {
+new RuleTester().run('no-document-body-mutation', rule, {
   valid: [
     {
       code: `const div = document.createElement('div');

test/e2e/issues/cookie-domain-attribute-non-ascii_test.ts

@@ -30,9 +30,8 @@ describe('Cookie domain attribute should not contain non-ASCII characters issue'
         img.onerror = c;
       });
       img.src = './issues/cookie-domain-non-ascii.rawresponse';
-      // This rule only applies to unit tests. TODO(crbug.com/421811012) update
-      // the rule so it is only run on front_end unit test files.
-      // eslint-disable-next-line rulesdir/no-widget-show-document-body
+      // This rule is only relevant for unit tests.
+      // eslint-disable-next-line rulesdir/no-document-body-mutation
       document.body.appendChild(img);
       await done;
     });