Skip to content

Commit 290f101

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
[AI Assistance] Use Promise.withResolvers
Make the code simpler and less traffic over CDP Bug: none Change-Id: I3cd1acf5fc1ca09ba753e82125cf134cedd89c9a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6250134 Auto-Submit: Nikolay Vitkov <[email protected]> Reviewed-by: Alex Rudenko <[email protected]> Commit-Queue: Alex Rudenko <[email protected]>
1 parent 2958176 commit 290f101

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

front_end/panels/ai_assistance/ExtensionScope.ts

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -160,29 +160,23 @@ export class ExtensionScope {
160160

161161
const freestylerBinding = `if (!globalThis.freestyler) {
162162
globalThis.freestyler = (args) => {
163-
let resolver;
164-
let rejecter;
165-
const p = new Promise((resolve, reject) => {
166-
resolver = resolve;
167-
rejecter = reject;
168-
});
163+
const {resolve, promise } = Promise.withResolvers();
169164
freestyler.callbacks.set(freestyler.id , {
170165
args: JSON.stringify(args),
171166
callbackId: freestyler.id,
172-
resolver,
173-
rejecter
167+
resolve,
174168
});
175169
${FREESTYLER_BINDING_NAME}(String(freestyler.id));
176170
freestyler.id++;
177-
return p;
171+
return promise;
178172
}
179173
freestyler.id = 1;
180174
freestyler.callbacks = new Map();
181175
freestyler.getArgs = (callbackId) => {
182176
return freestyler.callbacks.get(callbackId).args;
183177
}
184178
freestyler.respond = (callbackId, styleChanges) => {
185-
freestyler.callbacks.get(callbackId).resolver(styleChanges);
179+
freestyler.callbacks.get(callbackId).resolve(styleChanges);
186180
freestyler.callbacks.delete(callbackId);
187181
}
188182
}`;

0 commit comments

Comments
 (0)