Skip to content

Commit 29356d2

Browse files
Lightning00BladeDevtools-frontend LUCI CQ
authored andcommitted
Fix flaky test
Bug: none Change-Id: Iafdd82bab78df3853b55fcb671406c7d3b0cc484 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6263353 Auto-Submit: Nikolay Vitkov <[email protected]> Reviewed-by: Alina Varkki <[email protected]> Commit-Queue: Alina Varkki <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
1 parent 622903f commit 29356d2

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

test/e2e/helpers/console-helpers.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
$,
1111
$$,
1212
click,
13+
drainFrontendTaskQueue,
1314
getBrowserAndPages,
1415
goToResource,
1516
pasteText,
@@ -77,6 +78,7 @@ export async function filterConsoleMessages(frontend: puppeteer.Page, filter: st
7778
prompt!.focus();
7879
}, main);
7980
await pasteText(filter);
81+
await drainFrontendTaskQueue();
8082
await frontend.keyboard.press('Tab');
8183
if (filter.length) {
8284
await expectVeEvents([veChange('Toolbar > TextField: filter')], await veRoot());

test/e2e/settings/shortcut_settings_test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import {assert} from 'chai';
66

77
import {
8+
drainFrontendTaskQueue,
89
getBrowserAndPages,
910
timeout,
1011
waitFor,
@@ -73,6 +74,7 @@ describe('Shortcuts Settings tab', () => {
7374

7475
// make sure the command menu reflects the new shortcuts
7576
await frontend.keyboard.type('Show Shortcuts');
77+
await drainFrontendTaskQueue();
7678
const shortcutsItemText = await getSelectedItemText();
7779

7880
assert.strictEqual(shortcutsItemText, VS_CODE_SHORTCUTS_QUICK_OPEN_TEXT);

0 commit comments

Comments
 (0)