[AI Assistance] Fix issue with initiated graph

This was creating a recursive pattern.
While this may introduce a scenario that we send less data,
we avoid complete failure.

Bug: 399554771
Change-Id: I3cde4da47efb6c829496f470a8e92d0507328cd2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6310325
Commit-Queue: Nikolay Vitkov <[email protected]>
Commit-Queue: Alex Rudenko <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/panels/ai_assistance/data_formatters/NetworkRequestFormatter.ts

@@ -83,15 +83,15 @@ Request initiator chain:\n${this.formatRequestInitiatorChain()}`;
     const allowedOrigin = new URL(this.#request.url()).origin;
     let initiatorChain = '';
     let lineStart = '- URL: ';
-    const initiators = Logs.NetworkLog.NetworkLog.instance().initiatorGraphForRequest(this.#request).initiators;
+    const graph = Logs.NetworkLog.NetworkLog.instance().initiatorGraphForRequest(this.#request);
 
-    for (const initiator of Array.from(initiators).reverse()) {
+    for (const initiator of Array.from(graph.initiators).reverse()) {
       initiatorChain = initiatorChain + lineStart +
           NetworkRequestFormatter.formatInitiatorUrl(initiator.url(), allowedOrigin) + '\n';
       lineStart = '\t' + lineStart;
       if (initiator === this.#request) {
-        initiatorChain = this.#formatRequestInitiated(initiator, initiatorChain, lineStart, allowedOrigin);
-        break;
+        initiatorChain =
+            this.#formatRequestInitiated(graph.initiated, this.#request, initiatorChain, lineStart, allowedOrigin);
       }
     }
 
@@ -150,17 +150,28 @@ Request initiator chain:\n${this.formatRequestInitiatorChain()}`;
   }
 
   #formatRequestInitiated(
-      request: SDK.NetworkRequest.NetworkRequest, initiatorChain: string, lineStart: string,
-      allowedOrigin: string): string {
-    const initiated = Logs.NetworkLog.NetworkLog.instance().initiatorGraphForRequest(request).initiated;
-    initiated.forEach((v, initiatedRequest) => {
-      if (request === v) {
-        initiatorChain = initiatorChain + lineStart +
-            NetworkRequestFormatter.formatInitiatorUrl(initiatedRequest.url(), allowedOrigin) + '\n';
-        initiatorChain =
-            this.#formatRequestInitiated(initiatedRequest, initiatorChain, '\t' + lineStart, allowedOrigin);
+      initiated: Map<SDK.NetworkRequest.NetworkRequest, SDK.NetworkRequest.NetworkRequest>,
+      parentRequest: SDK.NetworkRequest.NetworkRequest,
+      initiatorChain: string,
+      lineStart: string,
+      allowedOrigin: string,
+      ): string {
+    const visited = new Set<SDK.NetworkRequest.NetworkRequest>();
+
+    // this.request should be already in the tree when build initiator part
+    visited.add(this.#request);
+    for (const [keyRequest, initiatedRequest] of initiated.entries()) {
+      if (initiatedRequest === parentRequest) {
+        if (!visited.has(keyRequest)) {
+          visited.add(keyRequest);
+          initiatorChain = initiatorChain + lineStart +
+              NetworkRequestFormatter.formatInitiatorUrl(keyRequest.url(), allowedOrigin) + '\n';
+          initiatorChain =
+              this.#formatRequestInitiated(initiated, keyRequest, initiatorChain, '\t' + lineStart, allowedOrigin);
+        }
       }
-    });
+    }
+
     return initiatorChain;
   }
 }

front_end/panels/network/RequestInitiatorView.ts

@@ -99,7 +99,7 @@ export class RequestInitiatorView extends UI.Widget.VBox {
     }
 
     const initiated = initiatorGraph.initiated;
-    this.depthFirstSearchTreeBuilder(initiated, (parent), this.request);
+    this.depthFirstSearchTreeBuilder(initiated, parent, this.request);
     return root;
   }
 

front_end/testing/AiAssistanceHelpers.ts

@@ -111,7 +111,7 @@ export function createNetworkRequest(opts?: {
   includeInitiators?: boolean,
 }): SDK.NetworkRequest.NetworkRequest {
   const networkRequest = SDK.NetworkRequest.NetworkRequest.create(
-      'requestId' as Protocol.Network.RequestId,
+      'requestId-0' as Protocol.Network.RequestId,
       opts?.url ?? Platform.DevToolsPath.urlString`https://www.example.com/script.js`,
       Platform.DevToolsPath.urlString``, null, null, null);
   networkRequest.statusCode = 200;
@@ -120,13 +120,13 @@ export function createNetworkRequest(opts?: {
 
   if (opts?.includeInitiators) {
     const initiatorNetworkRequest = SDK.NetworkRequest.NetworkRequest.create(
-        'requestId' as Protocol.Network.RequestId, Platform.DevToolsPath.urlString`https://www.initiator.com`,
+        'requestId-1' as Protocol.Network.RequestId, Platform.DevToolsPath.urlString`https://www.initiator.com`,
         Platform.DevToolsPath.urlString``, null, null, null);
     const initiatedNetworkRequest1 = SDK.NetworkRequest.NetworkRequest.create(
-        'requestId' as Protocol.Network.RequestId, Platform.DevToolsPath.urlString`https://www.example.com/1`,
+        'requestId-2' as Protocol.Network.RequestId, Platform.DevToolsPath.urlString`https://www.example.com/1`,
         Platform.DevToolsPath.urlString``, null, null, null);
     const initiatedNetworkRequest2 = SDK.NetworkRequest.NetworkRequest.create(
-        'requestId' as Protocol.Network.RequestId, Platform.DevToolsPath.urlString`https://www.example.com/2`,
+        'requestId-3' as Protocol.Network.RequestId, Platform.DevToolsPath.urlString`https://www.example.com/2`,
         Platform.DevToolsPath.urlString``, null, null, null);
 
     sinon.stub(Logs.NetworkLog.NetworkLog.instance(), 'initiatorGraphForRequest')