RPP: add insightKey to each insight

This allows you to easily, for a given Insight model's data when you
don't know the Insight, determine it.

Bug: 394552594
Change-Id: Ib1ddb829fd129b1516ce1900cc334922ca64984a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6276165
Commit-Queue: Alina Varkki <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Alina Varkki <[email protected]>

Author: jackfranklin

front_end/models/trace/insights/CLSCulprits.ts

@@ -523,6 +523,7 @@ function finalize(partialModel: PartialInsightModel<CLSCulpritsInsightModel>): C
       partialModel.worstCluster ? partialModel.topCulpritsByCluster.get(partialModel.worstCluster) ?? [] : [];
 
   return {
+    insightKey: 'CLSCulprits',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/DOMSize.ts

@@ -75,6 +75,7 @@ export function deps(): ['Renderer', 'AuctionWorklets', 'DOMStats'] {
 function finalize(partialModel: PartialInsightModel<DOMSizeInsightModel>): DOMSizeInsightModel {
   const relatedEvents = [...partialModel.largeLayoutUpdates, ...partialModel.largeStyleRecalcs];
   return {
+    insightKey: 'DOMSize',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/DocumentLatency.ts

@@ -171,6 +171,7 @@ function finalize(partialModel: PartialInsightModel<DocumentLatencyInsightModel>
   }
 
   return {
+    insightKey: 'DocumentLatency',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/DuplicateJavaScript.ts

@@ -39,6 +39,7 @@ export function deps(): ['Scripts', 'NetworkRequests'] {
 
 function finalize(partialModel: PartialInsightModel<DuplicateJavaScriptInsightModel>): DuplicateJavaScriptInsightModel {
   return {
+    insightKey: 'DuplicateJavaScript',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/FontDisplay.ts

@@ -46,6 +46,7 @@ export type FontDisplayInsightModel = InsightModel<typeof UIStrings, {
 
 function finalize(partialModel: PartialInsightModel<FontDisplayInsightModel>): FontDisplayInsightModel {
   return {
+    insightKey: 'FontDisplay',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/ForcedReflow.ts

@@ -190,6 +190,7 @@ function aggregateForcedReflow(
 
 function finalize(partialModel: PartialInsightModel<ForcedReflowInsightModel>): ForcedReflowInsightModel {
   return {
+    insightKey: 'ForcedReflow',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/ImageDelivery.ts

@@ -158,6 +158,7 @@ export function getOptimizationMessageWithBytes(optimization: ImageOptimization)
 
 function finalize(partialModel: PartialInsightModel<ImageDeliveryInsightModel>): ImageDeliveryInsightModel {
   return {
+    insightKey: 'ImageDelivery',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/InteractionToNextPaint.ts

@@ -66,6 +66,7 @@ export type INPInsightModel = InsightModel<typeof UIStrings, {
 
 function finalize(partialModel: PartialInsightModel<INPInsightModel>): INPInsightModel {
   return {
+    insightKey: 'InteractionToNextPaint',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/LCPDiscovery.ts

@@ -79,6 +79,7 @@ function finalize(partialModel: PartialInsightModel<LCPDiscoveryInsightModel>):
       [partialModel.lcpEvent, partialModel.lcpRequest] :
       [];
   return {
+    insightKey: 'LCPDiscovery',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),

front_end/models/trace/insights/LCPPhases.ts

@@ -93,6 +93,9 @@ export type LCPPhasesInsightModel = InsightModel<typeof UIStrings, {
   lcpRequest?: Types.Events.SyntheticNetworkRequest,
   phases?: LCPPhases,
 }>;
+export function isLCPPhases(model: InsightModel<{}, {}>): model is LCPPhasesInsightModel {
+  return model.title === UIStrings.title;
+}
 
 function anyValuesNaN(...values: number[]): boolean {
   return values.some(v => Number.isNaN(v));
@@ -154,6 +157,7 @@ function finalize(partialModel: PartialInsightModel<LCPPhasesInsightModel>): LCP
     relatedEvents.push(partialModel.lcpRequest);
   }
   return {
+    insightKey: 'LCPPhases',
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),