Convert no-lit-render-outside-of-view to TypeScript

Bug: 397586315
Change-Id: I74701e6c0390344cf673ae5caf900d568acfa012
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429284
Commit-Queue: Danil Somsikov <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>

Author: danilsomsikov

scripts/eslint_rules/lib/no-lit-render-outside-of-view.js renamed to scripts/eslint_rules/lib/no-lit-render-outside-of-view.ts

@@ -5,27 +5,28 @@
  * @fileoverview Rule to identify Lit render calls that are not inside of a
  * view function.
  */
-'use strict';
+import type {Rule} from 'eslint';
+import type {ArrowFunctionExpression, FunctionDeclaration, FunctionExpression} from 'estree';
 
-const {isLitHtmlRenderCall} = require('./utils.js');
+import {createRule} from './tsUtils.ts';
+import {isLitHtmlRenderCall} from './utils.js';
+type Node = Rule.Node;
 
-/**
- * @type {import('eslint').Rule.RuleModule}
- */
-module.exports = {
+export default createRule({
+  name: 'no-lit-render-outside-of-view',
   meta: {
     type: 'problem',
     docs: {
       description: 'Lit render calls should be inside of a view function',
       category: 'Possible Errors',
     },
     messages: {
-      litRenderShouldBeInsideOfView:
-        'Lit render calls should be inside of a view function',
+      litRenderShouldBeInsideOfView: 'Lit render calls should be inside of a view function',
     },
-    schema: [], // no options
+    schema: [],  // no options
   },
-  create : function(context) {
+  defaultOptions: [],
+  create: function(context) {
     return {
       CallExpression(node) {
         if (!isLitHtmlRenderCall(node)) {
@@ -38,8 +39,9 @@ module.exports = {
           });
           return;
         }
-        let functionNode = node.parent;
-        while (functionNode && !['FunctionDeclaration', 'FunctionExpression', 'ArrowFunctionExpression'].includes(functionNode.type)) {
+        let functionNode = node.parent as Node | undefined;
+        while (functionNode &&
+               !['FunctionDeclaration', 'FunctionExpression', 'ArrowFunctionExpression'].includes(functionNode.type)) {
           functionNode = functionNode.parent;
         }
         if (!functionNode) {
@@ -49,11 +51,11 @@ module.exports = {
           });
           return;
         }
-        /** @typedef {import('estree').FunctionDeclaration|import('estree').FunctionExpression|import('estree').ArrowFunctionExpression} FunctionLike */
-        const paramNames = /** @type {FunctionLike} */(functionNode).params.filter(p => p.type === 'Identifier').map(param => param.name);
+        type FunctionLike = FunctionDeclaration|FunctionExpression|ArrowFunctionExpression;
+        const paramNames =
+            (functionNode as FunctionLike).params.filter(p => p.type === 'Identifier').map(param => param.name);
         if (paramNames.length !== 3 || !paramNames[0].toLowerCase().endsWith('input') ||
-            !paramNames[1].toLowerCase().endsWith('output') ||
-            !paramNames[2].toLowerCase().endsWith('target')) {
+            !paramNames[1].toLowerCase().endsWith('output') || !paramNames[2].toLowerCase().endsWith('target')) {
           context.report({
             node,
             messageId: 'litRenderShouldBeInsideOfView',
@@ -88,4 +90,4 @@ module.exports = {
       },
     };
   }
-};
+});

scripts/eslint_rules/tests/no-lit-render-outside-of-view.test.js renamed to scripts/eslint_rules/tests/no-lit-render-outside-of-view.test.ts

@@ -1,10 +1,9 @@
 // Copyright 2025 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
-const rule = require('../lib/no-lit-render-outside-of-view.js');
+import rule from '../lib/no-lit-render-outside-of-view.ts';
 
-const {RuleTester} = require('./utils/utils.js');
+import {RuleTester} from './utils/tsUtils.ts';
 
 new RuleTester().run('no-lit-render-outside-of-view', rule, {
   valid: [