Skip to content

Commit 2da3fc4

Browse files
ktranDevtools-frontend LUCI CQ
authored andcommitted
Update Chrome (for Testing) PIN
Chromium pin updated to 132.0.6816.0 Changed roll to include an undefined check for aggregates that is required to account for chromium backend changes. Roll created at https://cr-buildbucket.appspot.com/build/8732234552970489025 Bug: 377200307 Change-Id: I62cc56ce73c66a9f810de632503d5762ac60b017 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5985373 Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]>
1 parent 53b4c2b commit 2da3fc4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ vars = {
4949
# Chrome version used for tests. It should be regularly updated to
5050
# match the Canary version listed here:
5151
# https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
52-
'chrome': '132.0.6811.0',
52+
'chrome': '132.0.6812.0',
5353

5454
# 'magic' text to tell depot_tools that git submodules should be accepted but
5555
# but parity with DEPS file is expected.

front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2469,7 +2469,7 @@ export abstract class HeapSnapshot {
24692469

24702470
private calculateDiffForClass(
24712471
baseAggregate: HeapSnapshotModel.HeapSnapshotModel.AggregateForDiff,
2472-
aggregate: HeapSnapshotModel.HeapSnapshotModel.Aggregate): HeapSnapshotModel.HeapSnapshotModel.Diff|null {
2472+
aggregate?: HeapSnapshotModel.HeapSnapshotModel.Aggregate): HeapSnapshotModel.HeapSnapshotModel.Diff|null {
24732473
const baseIds = baseAggregate.ids;
24742474
const baseIndexes = baseAggregate.indexes;
24752475
const baseSelfSizes = baseAggregate.selfSizes;
@@ -2480,7 +2480,7 @@ export abstract class HeapSnapshot {
24802480
let j = 0;
24812481
const l = baseIds.length;
24822482
const m = indexes.length;
2483-
const diff = new HeapSnapshotModel.HeapSnapshotModel.Diff(aggregate.name);
2483+
const diff = new HeapSnapshotModel.HeapSnapshotModel.Diff(aggregate ? aggregate.name : '');
24842484

24852485
const nodeB = this.createNode(indexes[j]);
24862486
while (i < l && j < m) {

0 commit comments

Comments
 (0)