Skip to content

Commit 2dbcb22

Browse files
yisiblDevtools-frontend LUCI CQ
authored andcommitted
[Autocomplete]: add corner-shape and corner-*-shape
will contain the following properties: - corner-shape - corner-top-left-shape - corner-top-right-shape - corner-bottom-right-shape - corner-bottom-left-shape DISABLE_THIRD_PARTY_CHECK=add corner-shape autocomplete Bug: 402346406 Change-Id: I86e8ca8e79c85cc5e5dc75d459fb886e7b0cc42c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6344150 Reviewed-by: Changhao Han <[email protected]> Commit-Queue: Changhao Han <[email protected]>
1 parent c1b4b68 commit 2dbcb22

File tree

3 files changed

+95
-0
lines changed

3 files changed

+95
-0
lines changed

front_end/core/sdk/CSSMetadata.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,11 @@ const filterValuePresetMap = new Map([
468468
['url', 'url(||)'],
469469
]);
470470

471+
const cornerShapeValuePresetMap = new Map([
472+
['superellipse(0.5)', 'superellipse(|0.5|)'],
473+
['superellipse(infinity)', 'superellipse(|infinity|)'],
474+
]);
475+
471476
const valuePresets = new Map([
472477
['filter', filterValuePresetMap],
473478
['backdrop-filter', filterValuePresetMap],
@@ -499,6 +504,7 @@ const valuePresets = new Map([
499504
['perspective', 'perspective(|10px|)'],
500505
]),
501506
],
507+
['corner-shape', cornerShapeValuePresetMap],
502508
]);
503509

504510
const distanceProperties = new Set<string>([
@@ -1371,6 +1377,19 @@ const extraPropertyValues = new Map<string, Set<string>>([
13711377
'ex alphabetic',
13721378
]),
13731379
],
1380+
[
1381+
'corner-shape',
1382+
new Set([
1383+
'round',
1384+
'scoop',
1385+
'bevel',
1386+
'notch',
1387+
'straight',
1388+
'squircle',
1389+
'superellipse(0.5)',
1390+
'superellipse(infinity)',
1391+
]),
1392+
],
13741393
]);
13751394

13761395
// Weight of CSS properties based on their usage from https://www.chromestatus.com/metrics/css/popularity

front_end/generated/SupportedCSSProperties.js

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1848,9 +1848,25 @@ export const generatedProperties = [
18481848
"name": "content-visibility"
18491849
},
18501850
{
1851+
"keywords": [
1852+
"round",
1853+
"scoop",
1854+
"bevel",
1855+
"notch",
1856+
"straight",
1857+
"squircle"
1858+
],
18511859
"name": "corner-bottom-left-shape"
18521860
},
18531861
{
1862+
"keywords": [
1863+
"round",
1864+
"scoop",
1865+
"bevel",
1866+
"notch",
1867+
"straight",
1868+
"squircle"
1869+
],
18541870
"name": "corner-bottom-right-shape"
18551871
},
18561872
{
@@ -1875,9 +1891,25 @@ export const generatedProperties = [
18751891
"name": "corner-start-start-shape"
18761892
},
18771893
{
1894+
"keywords": [
1895+
"round",
1896+
"scoop",
1897+
"bevel",
1898+
"notch",
1899+
"straight",
1900+
"squircle"
1901+
],
18781902
"name": "corner-top-left-shape"
18791903
},
18801904
{
1905+
"keywords": [
1906+
"round",
1907+
"scoop",
1908+
"bevel",
1909+
"notch",
1910+
"straight",
1911+
"squircle"
1912+
],
18811913
"name": "corner-top-right-shape"
18821914
},
18831915
{
@@ -5177,6 +5209,46 @@ export const generatedPropertyValues = {
51775209
"hidden"
51785210
]
51795211
},
5212+
"corner-bottom-left-shape": {
5213+
"values": [
5214+
"round",
5215+
"scoop",
5216+
"bevel",
5217+
"notch",
5218+
"straight",
5219+
"squircle"
5220+
]
5221+
},
5222+
"corner-bottom-right-shape": {
5223+
"values": [
5224+
"round",
5225+
"scoop",
5226+
"bevel",
5227+
"notch",
5228+
"straight",
5229+
"squircle"
5230+
]
5231+
},
5232+
"corner-top-left-shape": {
5233+
"values": [
5234+
"round",
5235+
"scoop",
5236+
"bevel",
5237+
"notch",
5238+
"straight",
5239+
"squircle"
5240+
]
5241+
},
5242+
"corner-top-right-shape": {
5243+
"values": [
5244+
"round",
5245+
"scoop",
5246+
"bevel",
5247+
"notch",
5248+
"straight",
5249+
"squircle"
5250+
]
5251+
},
51805252
"counter-increment": {
51815253
"values": [
51825254
"none"

third_party/blink/renderer/core/css/css_properties.json5

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2933,6 +2933,7 @@
29332933
field_template: "external",
29342934
default_value: "Superellipse::Round()",
29352935
include_paths: ["third_party/blink/renderer/core/style/superellipse.h"],
2936+
keywords: ["round", "scoop", "bevel", "notch", "straight", "squircle"],
29362937
type_name: "Superellipse",
29372938
converter: "ConvertCornerShape",
29382939
valid_for_first_letter: true,
@@ -2953,6 +2954,7 @@
29532954
field_template: "external",
29542955
default_value: "Superellipse::Round()",
29552956
include_paths: ["third_party/blink/renderer/core/style/superellipse.h"],
2957+
keywords: ["round", "scoop", "bevel", "notch", "straight", "squircle"],
29562958
type_name: "Superellipse",
29572959
converter: "ConvertCornerShape",
29582960
valid_for_first_letter: true,
@@ -2973,6 +2975,7 @@
29732975
field_template: "external",
29742976
default_value: "Superellipse::Round()",
29752977
include_paths: ["third_party/blink/renderer/core/style/superellipse.h"],
2978+
keywords: ["round", "scoop", "bevel", "notch", "straight", "squircle"],
29762979
type_name: "Superellipse",
29772980
converter: "ConvertCornerShape",
29782981
valid_for_first_letter: true,
@@ -2993,6 +2996,7 @@
29932996
field_template: "external",
29942997
default_value: "Superellipse::Round()",
29952998
include_paths: ["third_party/blink/renderer/core/style/superellipse.h"],
2999+
keywords: ["round", "scoop", "bevel", "notch", "straight", "squircle"],
29963000
type_name: "Superellipse",
29973001
converter: "ConvertCornerShape",
29983002
valid_for_first_letter: true,

0 commit comments

Comments
 (0)