[source-map] Assert sources index of mappings in unit tests

sourceIndex is currently broken for index source maps. Before we land
the fix lets add assertions for the sourceIndex when we check mappings.

[email protected]

Bug: 390337576
Change-Id: I51f6ea8447f5bd49002b656cdefad7695fd73db0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6179480
Commit-Queue: Simon Zünd <[email protected]>
Reviewed-by: Kim-Anh Tran <[email protected]>

Author: szuend

front_end/core/sdk/SourceMap.test.ts

@@ -100,9 +100,11 @@ describeWithEnvironment('SourceMap', () => {
   });
 
   function assertMapping(
-      actual: SDK.SourceMap.SourceMapEntry|null, expectedSourceURL: string|undefined,
-      expectedSourceLineNumber: number|undefined, expectedSourceColumnNumber: number|undefined) {
+      actual: SDK.SourceMap.SourceMapEntry|null, expectedSourceIndex: number|undefined,
+      expectedSourceURL: string|undefined, expectedSourceLineNumber: number|undefined,
+      expectedSourceColumnNumber: number|undefined) {
     assert.exists(actual);
+    assert.strictEqual(actual.sourceIndex, expectedSourceIndex, 'unexpected source index');
     assert.strictEqual(actual.sourceURL, expectedSourceURL, 'unexpected source URL');
     assert.strictEqual(actual.sourceLineNumber, expectedSourceLineNumber, 'unexpected source line number');
     assert.strictEqual(actual.sourceColumnNumber, expectedSourceColumnNumber, 'unexpected source column number');
@@ -163,13 +165,13 @@ describeWithEnvironment('SourceMap', () => {
 
     const sourceMap = new SDK.SourceMap.SourceMap(compiledUrl, sourceMapJsonUrl, mappingPayload);
 
-    assertMapping(sourceMap.findEntry(0, 9), 'example.js', 0, 9);
-    assertMapping(sourceMap.findEntry(0, 13), 'example.js', 0, 13);
-    assertMapping(sourceMap.findEntry(0, 15), 'example.js', 0, 25);
-    assertMapping(sourceMap.findEntry(0, 18), 'example.js', 2, 4);
-    assertMapping(sourceMap.findEntry(0, 25), 'example.js', 2, 11);
-    assertMapping(sourceMap.findEntry(0, 27), 'example.js', 2, 24);
-    assertMapping(sourceMap.findEntry(1, 0), undefined, undefined, undefined);
+    assertMapping(sourceMap.findEntry(0, 9), 0, 'example.js', 0, 9);
+    assertMapping(sourceMap.findEntry(0, 13), 0, 'example.js', 0, 13);
+    assertMapping(sourceMap.findEntry(0, 15), 0, 'example.js', 0, 25);
+    assertMapping(sourceMap.findEntry(0, 18), 0, 'example.js', 2, 4);
+    assertMapping(sourceMap.findEntry(0, 25), 0, 'example.js', 2, 11);
+    assertMapping(sourceMap.findEntry(0, 27), 0, 'example.js', 2, 24);
+    assertMapping(sourceMap.findEntry(1, 0), undefined, undefined, undefined, undefined);
 
     assertReverseMapping(sourceMap.sourceLineMapping(sourceUrlExample, 0, 0), 0, 0);
     assertReverseMapping(sourceMap.sourceLineMapping(sourceUrlExample, 1, 0), 0, 17);
@@ -269,8 +271,8 @@ describeWithEnvironment('SourceMap', () => {
     };
     const sourceMap = new SDK.SourceMap.SourceMap(compiledUrl, sourceMapJsonUrl, mappingPayload);
 
-    assertMapping(sourceMap.findEntry(0, 0), 'example.js', 0, 0);
-    assertMapping(sourceMap.findEntry(0, 2), 'example.js', 0, 2);
+    assertMapping(sourceMap.findEntry(0, 0), 0, 'example.js', 0, 0);
+    assertMapping(sourceMap.findEntry(0, 2), 0, 'example.js', 0, 2);
 
     const emptyEntry = sourceMap.findEntry(0, 1);
     assert.exists(emptyEntry);
@@ -287,7 +289,7 @@ describeWithEnvironment('SourceMap', () => {
     };
     const sourceMap = new SDK.SourceMap.SourceMap(compiledUrl, sourceMapJsonUrl, mappingPayload);
 
-    assertMapping(sourceMap.findEntry(0, 0), 'example.js', 0, 0);
+    assertMapping(sourceMap.findEntry(0, 0), 0, 'example.js', 0, 0);
     assertReverseMapping(sourceMap.sourceLineMapping(sourceUrlExample, 1, 0), 3, 1);
   });
 
@@ -306,10 +308,10 @@ describeWithEnvironment('SourceMap', () => {
       version: 3,
     });
 
-    assertMapping(sourceMap.findEntry(0, 0), 'example.js', 0, 3);
-    assertMapping(sourceMap.findEntry(0, 1), 'example.js', 0, 2);
-    assertMapping(sourceMap.findEntry(0, 2), 'example.js', 0, 1);
-    assertMapping(sourceMap.findEntry(0, 3), 'example.js', 0, 0);
+    assertMapping(sourceMap.findEntry(0, 0), 0, 'example.js', 0, 3);
+    assertMapping(sourceMap.findEntry(0, 1), 0, 'example.js', 0, 2);
+    assertMapping(sourceMap.findEntry(0, 2), 0, 'example.js', 0, 1);
+    assertMapping(sourceMap.findEntry(0, 3), 0, 'example.js', 0, 0);
   });
 
   it('can parse the multiple sections format', () => {
@@ -337,10 +339,10 @@ describeWithEnvironment('SourceMap', () => {
     const sourceMap = new SDK.SourceMap.SourceMap(compiledUrl, sourceMapJsonUrl, mappingPayload);
 
     assert.lengthOf(sourceMap.sourceURLs(), 3, 'unexpected number of original source URLs');
-    assertMapping(sourceMap.findEntry(0, 0), 'source1.js', 0, 0);
-    assertMapping(sourceMap.findEntry(0, 1), 'source1.js', 2, 1);
-    assertMapping(sourceMap.findEntry(2, 10), 'source3.js', 0, 0);
-    assertMapping(sourceMap.findEntry(2, 11), 'source3.js', 2, 1);
+    assertMapping(sourceMap.findEntry(0, 0), 0, 'source1.js', 0, 0);
+    assertMapping(sourceMap.findEntry(0, 1), 0, 'source1.js', 2, 1);
+    assertMapping(sourceMap.findEntry(2, 10), 0, 'source3.js', 0, 0);
+    assertMapping(sourceMap.findEntry(2, 11), 0, 'source3.js', 2, 1);
   });
 
   it('can parse source maps with ClosureScript names', () => {
@@ -407,8 +409,9 @@ describeWithEnvironment('SourceMap', () => {
     const sourceMapJsonUrl = urlString`wp://test/source-map.json`;
     const sourceMap = new SDK.SourceMap.SourceMap(compiledUrl, sourceMapJsonUrl, mappingPayload);
 
-    assertMapping(sourceMap.findEntry(1, 0), 'wp:///example.js', 3, 0);
-    assertMapping(sourceMap.findEntry(4, 0), 'wp:///other.js', 5, 0);
+    assertMapping(sourceMap.findEntry(0, 0), 0, 'wp:///example.js', 1, 0);
+    assertMapping(sourceMap.findEntry(1, 0), 1, 'wp:///example.js', 3, 0);
+    assertMapping(sourceMap.findEntry(4, 0), 2, 'wp:///other.js', 5, 0);
   });
 
   describe('compatibleForURL', () => {