Skip to content

Commit 311f667

Browse files
Kateryna ProkopenkoDevtools-frontend LUCI CQ
authored andcommitted
[GM3Restyling] Update rest of outline views
Also adjust micro buttton Bug: 325443114 Change-Id: If1672f7fa785785079d507b5b99a9e2911c20b50 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6213550 Auto-Submit: Kateryna Prokopenko <[email protected]> Reviewed-by: Kim-Anh Tran <[email protected]> Commit-Queue: Kateryna Prokopenko <[email protected]>
1 parent 7271b34 commit 311f667

File tree

12 files changed

+40
-52
lines changed

12 files changed

+40
-52
lines changed

front_end/panels/accessibility/axBreadcrumbs.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,6 @@
7979
background-color: var(--sys-color-tonal-container);
8080
}
8181

82-
.ax-breadcrumbs .ax-node.parent.inspected:focus::before {
83-
background-color: var(--sys-color-on-tonal-container);
84-
}
85-
8682
.ax-breadcrumbs .ax-node.inspected:focus {
8783
background-color: var(--sys-color-tonal-container);
8884
color: var(--sys-color-on-tonal-container);

front_end/panels/elements/elementsTreeOutline.css

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,20 +116,18 @@
116116
.elements-disclosure li.parent:not(.always-parent)::before {
117117
box-sizing: border-box;
118118
user-select: none;
119-
mask-image: var(--image-file-triangle-right);
119+
mask-image: var(--image-file-arrow-collapse);
120120
height: 14px;
121121
width: 14px;
122122
content: "\A0\A0";
123123
color: transparent;
124124
text-shadow: none;
125-
margin-left: -3px;
125+
margin: -3px 2px 0 -3px;
126126
background-color: var(--icon-default);
127-
transition: transform 200ms;
128127
}
129128

130129
.elements-disclosure li.parent.expanded::before {
131-
transform: rotate(90deg);
132-
margin-top: -2px;
130+
mask-image: var(--image-file-arrow-drop-down);
133131
}
134132

135133
.elements-disclosure li .selection {

front_end/panels/event_listeners/EventListenersView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ export class ObjectEventListenerBar extends UI.TreeOutline.TreeElement {
304304
const deleteButton = new Buttons.Button.Button();
305305
deleteButton.data = {
306306
variant: Buttons.Button.Variant.ICON,
307-
size: Buttons.Button.Size.SMALL,
307+
size: Buttons.Button.Size.MICRO,
308308
iconName: 'bin',
309309
jslogContext: 'delete-event-listener',
310310
};

front_end/panels/issues/issuesTree.css

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,11 @@
3333
}
3434

3535
.issues li.parent::before {
36-
margin-top: 10px;
36+
margin-top: 7px;
3737
}
3838

3939
.issues .affected-resources li.parent::before {
40-
margin-top: 3px;
41-
margin-right: 0;
40+
margin-top: 0;
4241
}
4342

4443
.issue-category,

front_end/panels/sources/SourcesPanel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1190,7 +1190,7 @@ export class SourcesPanel extends UI.Panel.Panel implements
11901190
vbox.setMinimumAndPreferredSizes(minToolbarWidth, 25, minToolbarWidth, 100);
11911191
this.sidebarPaneStack = UI.ViewManager.ViewManager.instance().createStackLocation(
11921192
this.revealDebuggerSidebar.bind(this), undefined, 'debug');
1193-
this.sidebarPaneStack.widget().element.classList.add('overflow-auto');
1193+
this.sidebarPaneStack.widget().element.classList.add('overflow-y-auto');
11941194
this.sidebarPaneStack.widget().show(vbox.element);
11951195
this.sidebarPaneStack.widget().element.appendChild(this.debuggerPausedMessage.element());
11961196
this.sidebarPaneStack.appendApplicableItems('sources.sidebar-top');

front_end/panels/sources/components/breakpointsView.css

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,19 @@ details > summary:hover {
5959
details > summary::before {
6060
display: block;
6161
user-select: none;
62-
mask-image: var(--image-file-triangle-right);
62+
mask-image: var(--image-file-arrow-collapse);
6363
background-color: var(--icon-default);
6464
content: "";
65-
height: 14px;
66-
min-width: 14px;
67-
max-width: 14px;
65+
height: 16px;
66+
min-width: 16px;
67+
max-width: 16px;
68+
margin-top: -2px;
6869
margin-left: -4px;
6970
overflow: hidden;
70-
transition: transform 200ms;
7171
}
7272

7373
details[open] > summary::before {
74-
transform: rotate(90deg);
74+
mask-image: var(--image-file-arrow-drop-down);
7575
}
7676

7777
.group-header {

front_end/ui/components/buttons/button.css

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,14 @@ button {
8282
--icon-size: var(--sys-size-8);
8383
}
8484

85+
&.micro {
86+
--button-height: var(--sys-size-8);
87+
--button-width: var(--sys-size-8);
88+
--icon-size: var(--sys-size-8);
89+
90+
border-radius: var(--sys-shape-corner-extra-small);
91+
}
92+
8593
&.toggled devtools-icon {
8694
color: var(--toggle-color); /* stylelint-disable-line plugin/use_theme_colors */
8795

@@ -168,24 +176,6 @@ button {
168176
devtools-icon {
169177
color: var(--icon-primary);
170178
}
171-
172-
&.micro {
173-
--button-height: var(--sys-size-7);
174-
175-
padding: 0 var(--sys-size-5);
176-
font-size: var(--sys-typescale-body4-size);
177-
font-weight: var(--ref-typeface-weight-medium);
178-
line-height: var(--sys-typescale-body4-line-height);
179-
180-
&:not(.icon):has(devtools-icon) {
181-
padding-left: var(--sys-size-3);
182-
}
183-
184-
&:not(.icon) devtools-icon {
185-
height: var(--sys-size-6);
186-
width: var(--sys-size-6);
187-
}
188-
}
189179
}
190180

191181
&:disabled {

front_end/ui/components/tree_outline/treeOutline.css

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,16 @@ li {
3333
.arrow-icon {
3434
display: block;
3535
user-select: none;
36-
mask-image: var(--image-file-triangle-right);
36+
mask-image: var(--image-file-arrow-collapse);
3737
background-color: var(--icon-default);
38+
margin-top: -2px;
39+
margin-right: 3px;
3840
content: "";
3941
text-shadow: none;
4042
height: 14px;
4143
width: 14px;
4244
overflow: hidden;
4345
flex: none;
44-
transition: transform 200ms;
4546
}
4647

4748
ul {
@@ -58,7 +59,7 @@ li:not(.parent) > .arrow-and-key-wrapper > .arrow-icon {
5859
}
5960

6061
li.parent.expanded > .arrow-and-key-wrapper > .arrow-icon {
61-
transform: rotate(90deg);
62+
mask-image: var(--image-file-arrow-drop-down);
6263
}
6364

6465
li.is-top-level {

front_end/ui/legacy/checkboxTextLabel.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ input.inside-datagrid {
3434
.dt-checkbox-text {
3535
overflow: hidden;
3636
text-overflow: ellipsis;
37+
white-space: nowrap;
3738

3839
input:disabled ~ & {
3940
opacity: 38%;

front_end/ui/legacy/components/object_ui/objectPropertiesSection.css

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717

1818
.object-properties-section li {
1919
user-select: text;
20-
}
2120

22-
.object-properties-section li::before {
23-
top: -1px;
24-
margin-right: 2px;
21+
&::before {
22+
margin-right: 2px;
23+
}
2524
}
2625

2726
.object-properties-section li.editing-sub-part {

0 commit comments

Comments
 (0)