Convert prefer-assert-length-of to TypeScript

Bug: chromium:397586315
Change-Id: Iafeb4022039487fdc80197d5d11acd048e62a9af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6441159
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Mathias Bynens <[email protected]>
Auto-Submit: Mathias Bynens <[email protected]>

Author: mathiasbynens

scripts/eslint_rules/lib/prefer-assert-length-of.js renamed to scripts/eslint_rules/lib/prefer-assert-length-of.ts

@@ -1,23 +1,15 @@
 // Copyright 2024 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
 
-/**
- * @fileoverview Prefer `assert.lengthOf` to check `length` of an array-like.
- */
-
-// ------------------------------------------------------------------------------
-// Rule Definition
-// ------------------------------------------------------------------------------
+import {createRule} from './tsUtils.ts';
 
 const EQUALITY_ASSERTIONS = new Set(['deepEqual', 'deepStrictEqual', 'equal', 'strictEqual']);
 
-/** @type {import('eslint').Rule.RuleModule} */
-module.exports = {
+export default createRule({
+  name: 'prefer-assert-length-of',
   meta: {
     type: 'suggestion',
-
     docs: {
       description: 'Prefer `assert.lengthOf` to check `length` of an array-like.',
       category: 'Best Practices',
@@ -26,15 +18,14 @@ module.exports = {
       useAssertLengthOf: 'Use `assert.lengthOf` to check `length` of an array-like',
     },
     fixable: 'code',
-    schema: [], // no options
+    schema: [],  // no options
   },
-  create: function (context) {
+  defaultOptions: [],
+  create: function(context) {
     function isAssertEquality(calleeNode) {
-      return calleeNode.type === 'MemberExpression' &&
-             calleeNode.object.type === 'Identifier' &&
-             calleeNode.object.name === 'assert' &&
-             calleeNode.property.type === 'Identifier' &&
-             EQUALITY_ASSERTIONS.has(calleeNode.property.name);
+      return calleeNode.type === 'MemberExpression' && calleeNode.object.type === 'Identifier' &&
+          calleeNode.object.name === 'assert' && calleeNode.property.type === 'Identifier' &&
+          EQUALITY_ASSERTIONS.has(calleeNode.property.name);
     }
 
     function isLengthProperty(argumentNode) {
@@ -43,8 +34,7 @@ module.exports = {
     }
 
     function isNumberLiteral(argumentNode) {
-      return argumentNode.type === 'Literal' &&
-             typeof argumentNode.value === 'number';
+      return argumentNode.type === 'Literal' && typeof argumentNode.value === 'number';
     }
 
     function reportError(node) {
@@ -76,4 +66,4 @@ module.exports = {
       }
     };
   },
-};
+});

scripts/eslint_rules/tests/prefer-assert-length-of.test.js renamed to scripts/eslint_rules/tests/prefer-assert-length-of.test.ts

@@ -1,11 +1,10 @@
 // Copyright 2024 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
 
-const rule = require('../lib/prefer-assert-length-of.js');
+import rule from '../lib/prefer-assert-length-of.ts';
 
-const {RuleTester} = require('./utils/utils.js');
+import {RuleTester} from './utils/tsUtils.ts';
 
 new RuleTester().run('prefer-assert-length-of', rule, {
   valid: [