Skip to content

Commit 33888c4

Browse files
Nancy LiDevtools-frontend LUCI CQ
authored andcommitted
[RPP Icicle blowtorch] UX improvement
- Restrict the width of the dialog. - Add a placeholder for the input. - Update the description text. Bug: 382009059 Change-Id: I865c14107d40e87f09662d51c58fd1cc40b7f409 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6082513 Reviewed-by: Jack Franklin <[email protected]> Commit-Queue: Nancy Li <[email protected]>
1 parent 7095032 commit 33888c4

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

front_end/panels/timeline/components/IgnoreListSetting.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const UIStrings = {
3030
/**
3131
* @description Text description for ignore list setting.
3232
*/
33-
ignoreListDescription: 'Add these exclusion rules would simplify the flame chart.',
33+
ignoreListDescription: 'Add regular expression rules to remove matching scripts from the flame chart.',
3434
/**
3535
*@description Pattern title in Framework Ignore List Settings Tab of the Settings
3636
*@example {ad.*?} regex
@@ -215,6 +215,8 @@ export class IgnoreListSetting extends HTMLElement {
215215
}
216216

217217
#initAddNewItem(): void {
218+
this.#newRegexInput.placeholder = '/framework\\.js$';
219+
218220
const checkboxHelpText = i18nString(UIStrings.ignoreScriptsWhoseNamesMatchNewRegex);
219221
const inputHelpText = i18nString(UIStrings.addNewRegex);
220222
UI.Tooltip.Tooltip.install(this.#newRegexCheckbox, checkboxHelpText);

front_end/panels/timeline/components/ignoreListSetting.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
* Use of this source code is governed by a BSD-style license that can be
44
* found in the LICENSE file.
55
*/
6+
.ignore-list-setting-content {
7+
width: 280px;
8+
}
9+
610
.ignore-list-setting-description {
711
margin-bottom: 5px;
812
}

0 commit comments

Comments
 (0)