Skip to content

Commit 33a08e0

Browse files
AlinaVarkkiDevtools-frontend LUCI CQ
authored andcommitted
[RPP] Add experiment for the alternative timeline navigation option
Bug: 313757601 Change-Id: Id595a18f4ef0d9e1c2c25d2be077c69cbb0a5104 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5970794 Commit-Queue: Jack Franklin <[email protected]> Reviewed-by: Jack Franklin <[email protected]> Auto-Submit: Alina Varkki <[email protected]>
1 parent 79670de commit 33a08e0

File tree

5 files changed

+10
-1
lines changed

5 files changed

+10
-1
lines changed

front_end/core/host/UserMetrics.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1028,10 +1028,11 @@ export enum DevtoolsExperiments {
10281028
'floating-entry-points-for-ai-assistance' = 101,
10291029
'timeline-experimental-insights' = 102,
10301030
'timeline-dim-unrelated-events' = 103,
1031+
'timeline-alternative-navigation' = 104,
10311032
/* eslint-enable @typescript-eslint/naming-convention */
10321033

10331034
// Increment this when new experiments are added.
1034-
MAX_VALUE = 104,
1035+
MAX_VALUE = 105,
10351036
}
10361037

10371038
export const enum CSSPropertyDocumentation {

front_end/core/root/Runtime.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ export const enum ExperimentName {
303303
FLOATING_ENTRY_POINTS_FOR_AI_ASSISTANCE = 'floating-entry-points-for-ai-assistance',
304304
TIMELINE_EXPERIMENTAL_INSIGHTS = 'timeline-experimental-insights',
305305
TIMELINE_DIM_UNRELATED_EVENTS = 'timeline-dim-unrelated-events',
306+
TIMELINE_ALTERNATIVE_NAVIGATION = 'timeline-alternative-navigation',
306307
// when adding to this enum, you'll need to also add to REGISTERED_EXPERIMENTS in EnvironmentHelpers.ts
307308
}
308309

front_end/entrypoints/main/MainImpl.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,11 @@ export class MainImpl {
418418
'Performance panel: enable dimming unrelated events in performance insights and search results',
419419
);
420420

421+
Root.Runtime.experiments.register(
422+
Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
423+
'Performance panel: enable a switch to an alternative timeline navigation option',
424+
);
425+
421426
Root.Runtime.experiments.enableExperimentsByDefault([
422427
'css-type-component-length-deprecate',
423428
Root.Runtime.ExperimentName.AUTOFILL_VIEW,

front_end/testing/EnvironmentHelpers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ const REGISTERED_EXPERIMENTS = [
134134
Root.Runtime.ExperimentName.EXTENSION_STORAGE_VIEWER,
135135
Root.Runtime.ExperimentName.TIMELINE_EXPERIMENTAL_INSIGHTS,
136136
Root.Runtime.ExperimentName.TIMELINE_DIM_UNRELATED_EVENTS,
137+
Root.Runtime.ExperimentName.TIMELINE_ALTERNATIVE_NAVIGATION,
137138
];
138139

139140
export async function initializeGlobalVars({reset = true} = {}) {

front_end/ui/visual_logging/KnownContextValues.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3020,6 +3020,7 @@ export const knownContextValues = new Set([
30203020
'thumbs-up',
30213021
'time',
30223022
'timeline',
3023+
'timeline-alternative-navigation',
30233024
'timeline-capture-layers-and-pictures',
30243025
'timeline-capture-selector-stats',
30253026
'timeline-compiled-sources',

0 commit comments

Comments
 (0)