Move code for calling dispatchHttpRequest to a common file

We will be using `dispatchHttpRequest` for AI Code Generation as well. Hence, moving it out of GdpClient

Bug: 448793181
Change-Id: Ic9224bbea94cde4d0c6ace0e82996a6131c51db4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7094290
Reviewed-by: Danil Somsikov <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Samiya Caur <[email protected]>

Author: Samiya Caur

config/gni/devtools_grd_files.gni

@@ -865,6 +865,7 @@ grd_files_unbundled_sources = [
   "front_end/core/common/Worker.js",
   "front_end/core/dom_extension/DOMExtension.js",
   "front_end/core/host/AidaClient.js",
+  "front_end/core/host/DispatchHttpRequestClient.js",
   "front_end/core/host/GdpClient.js",
   "front_end/core/host/InspectorFrontendHost.js",
   "front_end/core/host/InspectorFrontendHostAPI.js",

front_end/core/host/BUILD.gn

@@ -8,6 +8,7 @@ import("../../../scripts/build/ninja/devtools_module.gni")
 devtools_module("host") {
   sources = [
     "AidaClient.ts",
+    "DispatchHttpRequestClient.ts",
     "GdpClient.ts",
     "InspectorFrontendHost.ts",
     "InspectorFrontendHostAPI.ts",

front_end/core/host/DispatchHttpRequestClient.ts

@@ -0,0 +1,62 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {InspectorFrontendHostInstance} from './InspectorFrontendHost.js';
+import type {DispatchHttpRequestRequest, DispatchHttpRequestResult} from './InspectorFrontendHostAPI.js';
+
+export enum ErrorType {
+  HTTP_RESPONSE_UNAVAILABLE = 'HTTP_RESPONSE_UNAVAILABLE',
+  NOT_FOUND = 'NOT_FOUND',
+}
+
+export class DispatchHttpRequestError extends Error {
+  constructor(readonly type: ErrorType, options?: ErrorOptions) {
+    super(undefined, options);
+  }
+}
+
+export async function makeHttpRequest<R>(request: DispatchHttpRequestRequest): Promise<R> {
+  const response = await new Promise<DispatchHttpRequestResult>(resolve => {
+    InspectorFrontendHostInstance.dispatchHttpRequest(request, resolve);
+  });
+
+  debugLog({request, response});
+  if (response.statusCode === 404) {
+    throw new DispatchHttpRequestError(ErrorType.NOT_FOUND);
+  }
+
+  if ('response' in response && response.statusCode === 200) {
+    try {
+      return JSON.parse(response.response) as R;
+    } catch (err) {
+      throw new DispatchHttpRequestError(ErrorType.HTTP_RESPONSE_UNAVAILABLE, {cause: err});
+    }
+  }
+
+  throw new DispatchHttpRequestError(ErrorType.HTTP_RESPONSE_UNAVAILABLE);
+}
+
+function isDebugMode(): boolean {
+  return Boolean(localStorage.getItem('debugDispatchHttpRequestEnabled'));
+}
+
+function debugLog(...log: unknown[]): void {
+  if (!isDebugMode()) {
+    return;
+  }
+
+  // eslint-disable-next-line no-console
+  console.log('debugLog', ...log);
+}
+
+function setDebugDispatchHttpRequestEnabled(enabled: boolean): void {
+  if (enabled) {
+    localStorage.setItem('debugDispatchHttpRequestEnabled', 'true');
+  } else {
+    localStorage.removeItem('debugDispatchHttpRequestEnabled');
+  }
+}
+
+// @ts-expect-error
+globalThis.setDebugDispatchHttpRequestEnabled = setDebugDispatchHttpRequestEnabled;

front_end/core/host/GdpClient.ts

@@ -4,8 +4,8 @@
 
 import * as Root from '../root/root.js';
 
-import {InspectorFrontendHostInstance} from './InspectorFrontendHost.js';
-import type {DispatchHttpRequestRequest, DispatchHttpRequestResult} from './InspectorFrontendHostAPI.js';
+import * as DispatchHttpRequestClient from './DispatchHttpRequestClient.js';
+import type {DispatchHttpRequestRequest} from './InspectorFrontendHostAPI.js';
 
 export enum SubscriptionStatus {
   ENABLED = 'SUBSCRIPTION_STATE_ENABLED',
@@ -73,17 +73,6 @@ export interface GetProfileResponse {
   isEligible: boolean;
 }
 
-export enum GdpErrorType {
-  HTTP_RESPONSE_UNAVAILABLE = 'HTTP_RESPONSE_UNAVAILABLE',
-  NOT_FOUND = 'NOT_FOUND',
-}
-
-class GdpError extends Error {
-  constructor(readonly type: GdpErrorType, options?: ErrorOptions) {
-    super(undefined, options);
-  }
-}
-
 /**
  * The `batchGet` awards endpoint returns badge names with an
  * obfuscated user ID (e.g., `profiles/12345/awards/badge-name`).
@@ -99,27 +88,12 @@ export const GOOGLE_DEVELOPER_PROGRAM_PROFILE_LINK = 'https://developers.google.
 
 async function makeHttpRequest<R>(request: DispatchHttpRequestRequest): Promise<R> {
   if (!isGdpProfilesAvailable()) {
-    throw new GdpError(GdpErrorType.HTTP_RESPONSE_UNAVAILABLE);
-  }
-
-  const response = await new Promise<DispatchHttpRequestResult>(resolve => {
-    InspectorFrontendHostInstance.dispatchHttpRequest(request, resolve);
-  });
-
-  debugLog({request, response});
-  if (response.statusCode === 404) {
-    throw new GdpError(GdpErrorType.NOT_FOUND);
-  }
-
-  if ('response' in response && response.statusCode === 200) {
-    try {
-      return JSON.parse(response.response) as R;
-    } catch (err) {
-      throw new GdpError(GdpErrorType.HTTP_RESPONSE_UNAVAILABLE, {cause: err});
-    }
+    throw new DispatchHttpRequestClient.DispatchHttpRequestError(
+        DispatchHttpRequestClient.ErrorType.HTTP_RESPONSE_UNAVAILABLE);
   }
 
-  throw new GdpError(GdpErrorType.HTTP_RESPONSE_UNAVAILABLE);
+  const response = await DispatchHttpRequestClient.makeHttpRequest(request) as R;
+  return response;
 }
 
 const SERVICE_NAME = 'gdpService';
@@ -158,7 +132,8 @@ export class GdpClient {
         isEligible: true,
       };
     } catch (err: unknown) {
-      if (err instanceof GdpError && err.type === GdpErrorType.HTTP_RESPONSE_UNAVAILABLE) {
+      if (err instanceof DispatchHttpRequestClient.DispatchHttpRequestError &&
+          err.type === DispatchHttpRequestClient.ErrorType.HTTP_RESPONSE_UNAVAILABLE) {
         return null;
       }
     }
@@ -265,27 +240,6 @@ export class GdpClient {
   }
 }
 
-function isDebugMode(): boolean {
-  return Boolean(localStorage.getItem('debugGdpIntegrationEnabled'));
-}
-
-function debugLog(...log: unknown[]): void {
-  if (!isDebugMode()) {
-    return;
-  }
-
-  // eslint-disable-next-line no-console
-  console.log('debugLog', ...log);
-}
-
-function setDebugGdpIntegrationEnabled(enabled: boolean): void {
-  if (enabled) {
-    localStorage.setItem('debugGdpIntegrationEnabled', 'true');
-  } else {
-    localStorage.removeItem('debugGdpIntegrationEnabled');
-  }
-}
-
 export function isGdpProfilesAvailable(): boolean {
   const isBaseFeatureEnabled = Boolean(Root.Runtime.hostConfig.devToolsGdpProfiles?.enabled);
   const isBrandedBuild = Boolean(Root.Runtime.hostConfig.devToolsGdpProfilesAvailability?.enabled);
@@ -311,6 +265,3 @@ export function isBadgesEnabled(): boolean {
 export function isStarterBadgeEnabled(): boolean {
   return Boolean(Root.Runtime.hostConfig.devToolsGdpProfiles?.starterBadgeEnabled);
 }
-
-// @ts-expect-error
-globalThis.setDebugGdpIntegrationEnabled = setDebugGdpIntegrationEnabled;

front_end/core/host/host.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as AidaClient from './AidaClient.js';
+import * as DispatchHttpRequestClient from './DispatchHttpRequestClient.js';
 import * as GdpClient from './GdpClient.js';
 import * as InspectorFrontendHost from './InspectorFrontendHost.js';
 import * as InspectorFrontendHostAPI from './InspectorFrontendHostAPI.js';
@@ -12,6 +13,7 @@ import * as UserMetrics from './UserMetrics.js';
 
 export {
   AidaClient,
+  DispatchHttpRequestClient,
   GdpClient,
   InspectorFrontendHost,
   InspectorFrontendHostAPI,