[stack_trace] Forward the missing debug info in StackTraceModel

[email protected]

Bug: 433162438
Change-Id: If5055b577db554fc1c2dc4961c8fdc2a1f09cf8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6903183
Commit-Queue: Simon Zünd <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>

Author: szuend

front_end/models/stack_trace/StackTraceImpl.ts

@@ -70,13 +70,16 @@ export class FrameImpl implements StackTrace.StackTrace.Frame {
   readonly line: number;
   readonly column: number;
 
+  readonly missingDebugInfo?: StackTrace.StackTrace.MissingDebugInfo;
+
   constructor(
       url: string|undefined, uiSourceCode: Workspace.UISourceCode.UISourceCode|undefined, name: string|undefined,
-      line: number, column: number) {
+      line: number, column: number, missingDebugInfo?: StackTrace.StackTrace.MissingDebugInfo) {
     this.url = url;
     this.uiSourceCode = uiSourceCode;
     this.name = name;
     this.line = line;
     this.column = column;
+    this.missingDebugInfo = missingDebugInfo;
   }
 }

front_end/models/stack_trace/StackTraceModel.test.ts

@@ -167,6 +167,24 @@ describeWithMockConnection('StackTraceModel', () => {
       } catch {
       }
     });
+
+    it('forwards missing debug info', async () => {
+      const {model} = setup();
+      const translateFn: StackTraceImpl.StackTraceModel.TranslateRawFrames = (frames, _target) =>
+          Promise.resolve(frames.map(f => [{
+                                       url: f.url,
+                                       name: f.functionName,
+                                       line: f.lineNumber,
+                                       column: f.columnNumber,
+                                       missingDebugInfo: {type: StackTrace.StackTrace.MissingDebugInfoType.NO_INFO},
+                                     }]));
+
+      const stackTrace =
+          await model.createFromProtocolRuntime({callFrames: [protocolCallFrame('foo.js:1:foo:1:10')]}, translateFn);
+
+      assert.strictEqual(
+          stackTrace.syncFragment.frames[0].missingDebugInfo?.type, StackTrace.StackTrace.MissingDebugInfoType.NO_INFO);
+    });
   });
 
   describe('scriptInfoChanged', () => {
@@ -292,5 +310,26 @@ describeWithMockConnection('StackTraceModel', () => {
          sinon.assert.calledOnce(updatedSpyFull);
          sinon.assert.calledOnce(updatedSpySubSet);
        });
+
+    it('forwards missing debug info', async () => {
+      const {model} = setup();
+      const translateFn: StackTraceImpl.StackTraceModel.TranslateRawFrames = (frames, _target) =>
+          Promise.resolve(frames.map(f => [{
+                                       url: f.url,
+                                       name: f.functionName,
+                                       line: f.lineNumber,
+                                       column: f.columnNumber,
+                                       missingDebugInfo: {type: StackTrace.StackTrace.MissingDebugInfoType.NO_INFO},
+                                     }]));
+      const stackTrace = await model.createFromProtocolRuntime(
+          {callFrames: [protocolCallFrame('foo.js:1:foo:1:10')]}, identityTranslateFn);
+      assert.isUndefined(stackTrace.syncFragment.frames[0].missingDebugInfo);
+      const script = {scriptId: '1', sourceURL: 'bar.js'} as SDK.Script.Script;
+
+      await model.scriptInfoChanged(script, translateFn);
+
+      const frame = stackTrace.syncFragment.frames[0];
+      assert.strictEqual(frame.missingDebugInfo?.type, StackTrace.StackTrace.MissingDebugInfoType.NO_INFO);
+    });
   });
 });

front_end/models/stack_trace/StackTraceModel.ts

@@ -15,8 +15,8 @@ import {type FrameNode, type RawFrame, Trie} from './Trie.js';
  *
  * Any implementation must return an array with the same length as `frames`.
  */
-export type TranslateRawFrames = (frames: readonly RawFrame[], target: SDK.Target.Target) =>
-    Promise<Array<Array<Pick<StackTrace.StackTrace.Frame, 'url'|'uiSourceCode'|'name'|'line'|'column'>>>>;
+export type TranslateRawFrames = (frames: readonly RawFrame[], target: SDK.Target.Target) => Promise<
+    Array<Array<Pick<StackTrace.StackTrace.Frame, 'url'|'uiSourceCode'|'name'|'line'|'column'|'missingDebugInfo'>>>>;
 
 /**
  * The {@link StackTraceModel} is a thin wrapper around a fragment trie.
@@ -93,7 +93,8 @@ export class StackTraceModel extends SDK.SDKModel.SDKModel<unknown> {
     let i = 0;
     for (const node of fragment.node.getCallStack()) {
       node.frames = uiFrames[i++].map(
-          frame => new FrameImpl(frame.url, frame.uiSourceCode, frame.name, frame.line, frame.column));
+          frame => new FrameImpl(
+              frame.url, frame.uiSourceCode, frame.name, frame.line, frame.column, frame.missingDebugInfo));
     }
   }