Skip to content

Commit 39cc1b6

Browse files
Kateryna ProkopenkoDevtools-frontend LUCI CQ
authored andcommitted
Temporarily still use soft menu in Performance panel till backend lands
Bug: 368240754 Change-Id: Ibd7ff4a1620ab2771129c83b672904cf61501063 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5954343 Reviewed-by: Kim-Anh Tran <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]> Auto-Submit: Kateryna Prokopenko <[email protected]>
1 parent c01afb7 commit 39cc1b6

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

front_end/panels/timeline/TimelineFlameChartDataProvider.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,8 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
213213
return;
214214
}
215215

216-
const contextMenu = new UI.ContextMenu.ContextMenu(event);
216+
// TODO(crbug.com/368240754): Temporarily use soft menu for the shortcuts to show, till the accelerators backend CLs land.
217+
const contextMenu = new UI.ContextMenu.ContextMenu(event, {useSoftMenu: true});
217218

218219
if (UI.ActionRegistry.ActionRegistry.instance().hasAction('drjones.performance-panel-context')) {
219220
const aiNode = this.getAIEventNodeTreeFromEntryIndex(entryIndex);
@@ -229,6 +230,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
229230
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.MERGE_FUNCTION],
230231
jslogContext: 'hide-function',
231232
});
233+
hideEntryOption.setShortcut('H');
232234
hideEntryOption.setAccelerator(UI.KeyboardShortcut.Keys.H, [UI.KeyboardShortcut.Modifiers.None]);
233235
hideEntryOption.setIsDevToolsPerformanceMenuItem(true);
234236

@@ -238,6 +240,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
238240
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.COLLAPSE_FUNCTION],
239241
jslogContext: 'hide-children',
240242
});
243+
hideChildrenOption.setShortcut('C');
241244
hideChildrenOption.setAccelerator(UI.KeyboardShortcut.Keys.C, [UI.KeyboardShortcut.Modifiers.None]);
242245
hideChildrenOption.setIsDevToolsPerformanceMenuItem(true);
243246

@@ -248,6 +251,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
248251
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.COLLAPSE_REPEATING_DESCENDANTS],
249252
jslogContext: 'hide-repeating-children',
250253
});
254+
hideRepeatingChildrenOption.setShortcut('R');
251255
hideRepeatingChildrenOption.setAccelerator(UI.KeyboardShortcut.Keys.R, [UI.KeyboardShortcut.Modifiers.None]);
252256
hideRepeatingChildrenOption.setIsDevToolsPerformanceMenuItem(true);
253257

@@ -257,6 +261,7 @@ export class TimelineFlameChartDataProvider extends Common.ObjectWrapper.ObjectW
257261
disabled: !possibleActions?.[PerfUI.FlameChart.FilterAction.RESET_CHILDREN],
258262
jslogContext: 'reset-children',
259263
});
264+
resetChildrenOption.setShortcut('U');
260265
resetChildrenOption.setAccelerator(UI.KeyboardShortcut.Keys.U, [UI.KeyboardShortcut.Modifiers.None]);
261266
resetChildrenOption.setIsDevToolsPerformanceMenuItem(true);
262267

0 commit comments

Comments
 (0)