[AI Assistance] Update parser to include the AidaResponse

Moves the function calling parts to parsing and extends the types.
Also noticed that the ChildAgents had the same impl as the base
so remove it.

Bug: 360751542
Change-Id: I859557c2463637391e4fac392d943b8699c234ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6074132
Commit-Queue: Alex Rudenko <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

front_end/core/host/AidaClient.ts

@@ -33,6 +33,11 @@ export interface Content {
 
 export type Part = {
   text: string,
+}|{
+  functionCall: {
+    name: string,
+    args: Record<string, unknown>,
+  },
 }|{
   functionResponse: {
     name: string,
@@ -60,12 +65,17 @@ interface BaseFunctionParam {
 interface FunctionPrimitiveParams extends BaseFunctionParam {
   type: ParametersTypes.BOOLEAN|ParametersTypes.INTEGER|ParametersTypes.STRING|ParametersTypes.BOOLEAN;
 }
+
+interface FunctionArrayParam extends BaseFunctionParam {
+  type: ParametersTypes.ARRAY;
+  items: FunctionPrimitiveParams[];
+}
+
 interface FunctionObjectParam extends BaseFunctionParam {
   type: ParametersTypes.OBJECT;
   // TODO: this can be also be ObjectParams
-  properties: {[Key in string]: FunctionPrimitiveParams};
+  properties: {[Key in string]: FunctionPrimitiveParams|FunctionArrayParam};
 }
-// TODO: Add FunctionArrayParam
 
 /**
  * More about function declaration can be read at

front_end/panels/freestyler/AiAgent.ts

@@ -156,7 +156,7 @@ export abstract class ConversationContext<T> {
   }
 }
 
-interface AgentFunctionDefinition extends Host.AidaClient.FunctionDeclaration {
+export interface AgentFunctionDefinition extends Host.AidaClient.FunctionDeclaration {
   method: (...args: any[]) => Record<string, unknown>;
 }
 
@@ -191,7 +191,7 @@ export abstract class AiAgent<T> {
   #structuredLog: Array<{
     request: Host.AidaClient.AidaRequest,
     response: string,
-    rawResponse?: Host.AidaClient.AidaResponse,
+    aidaResponse?: Host.AidaClient.AidaResponse,
   }> = [];
 
   constructor(opts: AgentOptions) {
@@ -265,34 +265,34 @@ export abstract class AiAgent<T> {
           request: Host.AidaClient.AidaRequest,
           options?: {signal?: AbortSignal},
           ): AsyncGenerator<{parsedResponse: ParsedResponse, completed: boolean, rpcId?: number}, void, void> {
-    let rawResponse: Host.AidaClient.AidaResponse|undefined = undefined;
+    let aidaResponse: Host.AidaClient.AidaResponse|undefined = undefined;
     let response = '';
     let rpcId: number|undefined;
-    for await (rawResponse of this.#aidaClient.fetch(request, options)) {
-      response = rawResponse.explanation;
-      rpcId = rawResponse.metadata.rpcGlobalId ?? rpcId;
+    for await (aidaResponse of this.#aidaClient.fetch(request, options)) {
+      response = aidaResponse.explanation;
+      rpcId = aidaResponse.metadata.rpcGlobalId ?? rpcId;
 
-      if (rawResponse.functionCall) {
+      if (aidaResponse.functionCall) {
         throw new Error('Function calling not supported yet');
       }
 
-      const parsedResponse = this.parseResponse(response);
+      const parsedResponse = this.parseResponse(aidaResponse);
       yield {
         rpcId,
         parsedResponse,
-        completed: rawResponse.completed,
+        completed: aidaResponse.completed,
       };
     }
 
     debugLog({
       request,
-      response: rawResponse,
+      response: aidaResponse,
     });
 
     this.#structuredLog.push({
       request: structuredClone(request),
       response,
-      rawResponse,
+      aidaResponse,
     });
     localStorage.setItem('freestylerStructuredLog', JSON.stringify(this.#structuredLog));
   }
@@ -341,9 +341,12 @@ export abstract class AiAgent<T> {
     return query;
   }
 
-  parseResponse(response: string): ParsedResponse {
+  parseResponse(response: Host.AidaClient.AidaResponse): ParsedResponse {
+    if (response.functionCall && response.completed) {
+      throw new Error('Function calling not supported yet');
+    }
     return {
-      answer: response,
+      answer: response.explanation,
     };
   }
 

front_end/panels/freestyler/DrJonesFileAgent.ts

@@ -15,7 +15,6 @@ import {
   type ContextDetail,
   type ContextResponse,
   ConversationContext,
-  type ParsedResponse,
   type RequestOptions,
   ResponseType,
 } from './AiAgent.js';
@@ -143,12 +142,6 @@ export class DrJonesFileAgent extends AiAgent<Workspace.UISourceCode.UISourceCod
         selectedFile ? `# Selected file\n${formatFile(selectedFile.getItem())}\n\n# User request\n\n` : '';
     return `${fileEnchantmentQuery}${query}`;
   }
-
-  override parseResponse(response: string): ParsedResponse {
-    return {
-      answer: response,
-    };
-  }
 }
 
 function createContextDetailsForDrJonesFileAgent(

front_end/panels/freestyler/DrJonesNetworkAgent.ts

@@ -16,7 +16,6 @@ import {
   type ContextDetail,
   type ContextResponse,
   ConversationContext,
-  type ParsedResponse,
   type RequestOptions,
   ResponseType,
 } from './AiAgent.js';
@@ -169,12 +168,6 @@ export class DrJonesNetworkAgent extends AiAgent<SDK.NetworkRequest.NetworkReque
         '';
     return `${networkEnchantmentQuery}${query}`;
   }
-
-  override parseResponse(response: string): ParsedResponse {
-    return {
-      answer: response,
-    };
-  }
 }
 
 function formatLines(title: string, lines: string[], maxLength: number): string {

front_end/panels/freestyler/DrJonesPerformanceAgent.ts

@@ -13,7 +13,6 @@ import {
   AiAgent,
   type ContextResponse,
   ConversationContext,
-  type ParsedResponse,
   type RequestOptions,
   ResponseType,
 } from './AiAgent.js';
@@ -217,10 +216,4 @@ export class DrJonesPerformanceAgent extends AiAgent<TimelineUtils.AICallTree.AI
     const perfEnhancementQuery = aiCallTree ? `${treeStr}\n\n# User request\n\n` : '';
     return `${perfEnhancementQuery}${query}`;
   }
-
-  override parseResponse(response: string): ParsedResponse {
-    return {
-      answer: response,
-    };
-  }
 }