Remove unnecessary changes hints in the Styles tab code

Bug: 406453050
Change-Id: If12eb77019be34ab8f62c903009766ce57d85c3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400619
Commit-Queue: Changhao Han <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>

Author: hanselfmu-chromium

front_end/panels/elements/StylePropertiesSection.ts

@@ -161,7 +161,7 @@ export class StylePropertiesSection {
   private sectionIdx = 0;
 
   #customHeaderText: string|undefined;
-  readonly #specificiyTooltips: HTMLSpanElement;
+  readonly #specificityTooltips: HTMLSpanElement;
   static #nextSpecificityTooltipId = 0;
 
   constructor(
@@ -227,7 +227,7 @@ export class StylePropertiesSection {
     selectorContainer.appendChild(this.selectorElement);
     this.selectorElement.addEventListener('mouseenter', this.onMouseEnterSelector.bind(this), false);
     this.selectorElement.addEventListener('mouseleave', this.onMouseOutSelector.bind(this), false);
-    this.#specificiyTooltips = selectorContainer.createChild('span');
+    this.#specificityTooltips = selectorContainer.createChild('span');
 
     // We only add braces for style rules with selectors and non-style rules, which create their own sections.
     if (headerText.length > 0 || !(rule instanceof SDK.CSSRule.CSSStyleRule)) {
@@ -1173,7 +1173,7 @@ export class StylePropertiesSection {
       selectors: Array<{text: string, specificity?: Protocol.CSS.Specificity}>, matchingSelectors: boolean[],
       elementToSelectorIndex: WeakMap<Element, number>): void {
     this.selectorElement.removeChildren();
-    this.#specificiyTooltips.removeChildren();
+    this.#specificityTooltips.removeChildren();
     for (const [i, selector] of selectors.entries()) {
       if (i > 0) {
         this.selectorElement.append(', ');
@@ -1186,7 +1186,7 @@ export class StylePropertiesSection {
       if (specificityTooltipId && selector.specificity) {
         span.setAttribute('aria-details', specificityTooltipId);
         const PH1 = `(${selector.specificity.a},${selector.specificity.b},${selector.specificity.c})`;
-        const tooltip = this.#specificiyTooltips.appendChild(new Tooltips.Tooltip.Tooltip({
+        const tooltip = this.#specificityTooltips.appendChild(new Tooltips.Tooltip.Tooltip({
           id: specificityTooltipId,
           anchor: span,
           variant: 'rich',
@@ -1468,7 +1468,7 @@ export class StylePropertiesSection {
     // Reset selector marks in group, and normalize whitespace.
     const textContent = element.textContent;
     if (textContent !== null) {
-      this.#specificiyTooltips.querySelectorAll('devtools-tooltip')?.forEach(tooltip => tooltip.hidePopover());
+      this.#specificityTooltips.querySelectorAll('devtools-tooltip')?.forEach(tooltip => tooltip.hidePopover());
       element.textContent = textContent.replace(/\s+/g, ' ').trim();
     }
 

front_end/panels/elements/StylesSidebarPane.ts

@@ -44,10 +44,9 @@ import * as Protocol from '../../generated/protocol.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import type * as Formatter from '../../models/formatter/formatter.js';
 import * as TextUtils from '../../models/text_utils/text_utils.js';
-import * as Workspace from '../../models/workspace/workspace.js';
+import type * as Workspace from '../../models/workspace/workspace.js';
 import * as WorkspaceDiff from '../../models/workspace_diff/workspace_diff.js';
 import {PanelUtils} from '../../panels/utils/utils.js';
-import * as DiffView from '../../ui/components/diff_view/diff_view.js';
 import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 import * as InlineEditor from '../../ui/legacy/components/inline_editor/inline_editor.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
@@ -1325,73 +1324,6 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
     return sections;
   }
 
-  async trackURLForChanges(url: Platform.DevToolsPath.UrlString): Promise<void> {
-    const currentTracker = this.#urlToChangeTracker.get(url);
-    if (currentTracker) {
-      WorkspaceDiff.WorkspaceDiff.workspaceDiff().unsubscribeFromDiffChange(
-          currentTracker.uiSourceCode, currentTracker.diffChangeCallback);
-    }
-
-    // We get a refreshed uiSourceCode each time because the underlying instance may be recreated.
-    const uiSourceCode = Workspace.Workspace.WorkspaceImpl.instance().uiSourceCodeForURL(url);
-    if (!uiSourceCode) {
-      return;
-    }
-    const diffChangeCallback = this.refreshChangedLines.bind(this, uiSourceCode);
-    WorkspaceDiff.WorkspaceDiff.workspaceDiff().subscribeToDiffChange(uiSourceCode, diffChangeCallback);
-    const newTracker = {
-      uiSourceCode,
-      changedLines: new Set<number>(),
-      diffChangeCallback,
-    };
-    this.#urlToChangeTracker.set(url, newTracker);
-    await this.refreshChangedLines(newTracker.uiSourceCode);
-  }
-
-  isPropertyChanged(property: SDK.CSSProperty.CSSProperty): boolean {
-    const url = property.ownerStyle.parentRule?.resourceURL();
-    if (!url) {
-      return false;
-    }
-    const changeTracker = this.#urlToChangeTracker.get(url);
-    if (!changeTracker) {
-      return false;
-    }
-    const {changedLines, formattedCurrentMapping} = changeTracker;
-    const uiLocation = Bindings.CSSWorkspaceBinding.CSSWorkspaceBinding.instance().propertyUILocation(property, true);
-    if (!uiLocation) {
-      return false;
-    }
-    if (!formattedCurrentMapping) {
-      // UILocation's lineNumber starts at 0, but changedLines start at 1.
-      return changedLines.has(uiLocation.lineNumber + 1);
-    }
-    const formattedLineNumber =
-        formattedCurrentMapping.originalToFormatted(uiLocation.lineNumber, uiLocation.columnNumber)[0];
-    return changedLines.has(formattedLineNumber + 1);
-  }
-
-  private async refreshChangedLines(uiSourceCode: Workspace.UISourceCode.UISourceCode): Promise<void> {
-    const changeTracker = this.#urlToChangeTracker.get(uiSourceCode.url());
-    if (!changeTracker) {
-      return;
-    }
-    const diffResponse = await WorkspaceDiff.WorkspaceDiff.workspaceDiff().requestDiff(uiSourceCode);
-    const changedLines = new Set<number>();
-    changeTracker.changedLines = changedLines;
-    if (!diffResponse) {
-      return;
-    }
-    const {diff, formattedCurrentMapping} = diffResponse;
-    const {rows} = DiffView.DiffView.buildDiffRows(diff);
-    for (const row of rows) {
-      if (row.type === DiffView.DiffView.RowType.ADDITION) {
-        changedLines.add(row.currentLineNumber);
-      }
-    }
-    changeTracker.formattedCurrentMapping = formattedCurrentMapping;
-  }
-
   async getFormattedChanges(): Promise<string> {
     let allChanges = '';
     for (const [url, {uiSourceCode}] of this.#urlToChangeTracker) {