[PP] Rename stack trace helper

getZeroIndexedStackTraceForEvent->getZeroIndexedStackTraceInEventPayload

To make it clear that it returns the stack trace contained in the
payload of a trace event. This way it's easier to distinguish from the
StackTraceForEvent.ts helper, which can build async stack traces using
the call hierarchy built by the RendererHandler.

Bug: 389056697
Change-Id: I171d2d2f955a6c78f87f8ce849af9ea4bf7258fc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6449137
Reviewed-by: Nancy Li <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>

Author: and-oli

front_end/models/trace/handlers/NetworkRequestsHandler.ts

@@ -490,7 +490,7 @@ export async function finalize(): Promise<void> {
 
     // Establish initiator relationships
     const initiatorUrl = networkEvent.args.data.initiator?.url ||
-        Helpers.Trace.getZeroIndexedStackTraceForEvent(networkEvent)?.at(0)?.url;
+        Helpers.Trace.getZeroIndexedStackTraceInEventPayload(networkEvent)?.at(0)?.url;
     if (initiatorUrl) {
       const events = networkRequestEventByInitiatorUrl.get(initiatorUrl) ?? [];
       events.push(networkEvent);

front_end/models/trace/helpers/Trace.ts

@@ -435,7 +435,7 @@ export function getZeroIndexedLineAndColumnForEvent(event: Types.Events.Event):
  * stack. If you want to obtain the whole stack trace you might need to
  * use the @see Trace.Extras.StackTraceForEvent util.
  */
-export function getZeroIndexedStackTraceForEvent(event: Types.Events.Event): Types.Events.CallFrame[]|null {
+export function getZeroIndexedStackTraceInEventPayload(event: Types.Events.Event): Types.Events.CallFrame[]|null {
   const stack = stackTraceInEvent(event);
   if (!stack) {
     return null;

front_end/models/trace/insights/ForcedReflow.ts

@@ -153,7 +153,7 @@ function finalize(partialModel: PartialInsightModel<ForcedReflowInsightModel>):
 function getBottomCallFrameForEvent(event: Types.Events.Event, traceParsedData: Handlers.Types.ParsedTrace):
     Types.Events.CallFrame|Protocol.Runtime.CallFrame|null {
   const profileStackTrace = Extras.StackTraceForEvent.get(event, traceParsedData);
-  const eventStackTrace = Helpers.Trace.getZeroIndexedStackTraceForEvent(event);
+  const eventStackTrace = Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event);
 
   return profileStackTrace?.callFrames[0] ?? eventStackTrace?.[0] ?? null;
 }

front_end/models/trace/insights/NetworkDependencyTree.ts

@@ -110,7 +110,7 @@ function isCritical(request: Types.Events.SyntheticNetworkRequest, context: Insi
   // Requests that have no initiatorRequest are typically ambiguous late-load assets.
   // Even on the off chance they were important, we don't have any parent to display for them.
   const initiatorUrl =
-      request.args.data.initiator?.url || Helpers.Trace.getZeroIndexedStackTraceForEvent(request)?.at(0)?.url;
+      request.args.data.initiator?.url || Helpers.Trace.getZeroIndexedStackTraceInEventPayload(request)?.at(0)?.url;
   if (!initiatorUrl) {
     return false;
   }

front_end/panels/timeline/TimelineUIUtils.ts

@@ -814,7 +814,7 @@ export class TimelineUIUtils {
     return detailsText;
 
     function linkifyTopCallFrameAsText(): string|null {
-      const frame = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(event)?.at(0) ?? null;
+      const frame = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event)?.at(0) ?? null;
       if (!frame) {
         return null;
       }
@@ -885,7 +885,7 @@ export class TimelineUIUtils {
         details = document.createElement('span');
 
         // FunctionCall events have an args.data that could be a CallFrame, if all the details are present, so we check for that.
-        const callFrame = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(event)?.at(0);
+        const callFrame = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event)?.at(0);
         if (Trace.Types.Events.isFunctionCall(event) && callFrame) {
           UI.UIUtils.createTextChild(
               details,
@@ -1004,7 +1004,7 @@ export class TimelineUIUtils {
   static linkifyTopCallFrame(
       event: Trace.Types.Events.Event, target: SDK.Target.Target|null, linkifier: LegacyComponents.Linkifier.Linkifier,
       isFreshRecording = false): Element|null {
-    let frame = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(event)?.[0];
+    let frame = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event)?.[0];
     if (Trace.Types.Events.isProfileCall(event)) {
       frame = event.callFrame;
     }
@@ -1644,7 +1644,7 @@ export class TimelineUIUtils {
       }
     }
 
-    const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(event);
+    const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event);
     if (Trace.Types.Events.isUserTiming(event) || Trace.Types.Extensions.isSyntheticExtensionEntry(event) ||
         Trace.Types.Events.isProfileCall(event) || initiator || initiatorFor || stackTrace ||
         parsedTrace?.Invalidations.invalidationsForEvent.get(event)) {
@@ -1831,7 +1831,7 @@ export class TimelineUIUtils {
       // TODO(andoli): also build stack trace component for other events
       // that have a stack trace using the StackTraceForEvent helper.
     } else {
-      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(event);
+      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event);
       if (stackTrace?.length) {
         contentHelper.addSection(stackLabel);
         contentHelper.createChildStackTraceElement(TimelineUIUtils.stackTraceFromCallFrames(stackTrace));
@@ -1864,7 +1864,7 @@ export class TimelineUIUtils {
     if (initiator) {
       // If we have an initiator for the event, we can show its stack trace, a link to reveal the initiator,
       // and the time since the initiator (Pending For).
-      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(initiator);
+      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(initiator);
       if (stackTrace) {
         contentHelper.addSection(initiatorStackLabel);
         contentHelper.createChildStackTraceElement(TimelineUIUtils.stackTraceFromCallFrames(stackTrace.map(frame => {
@@ -1992,7 +1992,7 @@ export class TimelineUIUtils {
     const generatedItems = new Set<string>();
 
     for (const invalidation of invalidations) {
-      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(invalidation);
+      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(invalidation);
       let scriptLink: HTMLElement|null = null;
       const callFrame = stackTrace?.at(0);
       if (callFrame) {

front_end/panels/timeline/components/NetworkRequestDetails.ts

@@ -305,7 +305,7 @@ export class NetworkRequestDetails extends HTMLElement {
     let link: HTMLElement|null = null;
     // If we have a stack trace, that is the most reliable way to get the initiator data and display a link to the source.
     if (hasStackTrace) {
-      const topFrame = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(this.#networkRequest)?.at(0) ?? null;
+      const topFrame = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(this.#networkRequest)?.at(0) ?? null;
       if (topFrame) {
         link = this.#linkifier.maybeLinkifyConsoleCallFrame(
             this.#maybeTarget, topFrame, {tabStop: true, inlineFrameIndex: 0, showColumnNumber: true});

front_end/panels/timeline/utils/EntityMapper.ts

@@ -102,7 +102,7 @@ export class EntityMapper {
     // The events that don't match the source location, but that we should keep mapped to its current entity.
     const unrelatedEvents: Trace.Types.Events.Event[] = [];
     currentEntityEvents?.forEach(e => {
-      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(e);
+      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(e);
       const cf = stackTrace?.at(0);
 
       const matchesCallFrame = cf && Trace.Helpers.Trace.isMatchingCallFrame(cf, callFrame);

front_end/panels/timeline/utils/SourceMapsResolver.ts

@@ -78,7 +78,7 @@ export class SourceMapsResolver extends EventTarget {
     if (Trace.Types.Events.isProfileCall(entry)) {
       callFrame = entry.callFrame;
     } else {
-      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceForEvent(entry);
+      const stackTrace = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(entry);
       if (stackTrace === null || stackTrace.length < 1) {
         return null;
       }